Change blackboard write/readString prototype

Those functions are used in one place and let the caller transform a
std::string to a char * which makes the use of alloca necessary.
Moreover, the readString cannot know if the pointer given in input
points to a buffer with enough space, making it dangerous.

This patch reworks the API so that write/readString() get std::string
and lets the implementation play with char *. This also allows to get
rid of alloca() use which is quite dangerous.

Change-Id: I973e4987278289bb914c4e194b86e924a1c88a6d
Signed-off-by: Sebastien Gonzalve <sebastien.gonzalve@intel.com>

1 files changed, 3 insertions, 2 deletions

diff --git a/parameter/ParameterBlackboard.h b/parameter/ParameterBlackboard.h
index 111208a..bd48cc4 100644
--- a/parameter/ParameterBlackboard.h
+++ b/parameter/ParameterBlackboard.h
@@ -31,6 +31,7 @@
 
 #include <stdint.h>
 #include "BinaryStream.h"
+#include <string>
 
 class CParameterBlackboard
 {
@@ -45,8 +46,8 @@ public:
     // Single parameter access
     void writeInteger(const void* pvSrcData, uint32_t uiSize, uint32_t uiOffset, bool bBigEndian);
     void readInteger(void* pvDstData, uint32_t uiSize, uint32_t uiOffset, bool bBigEndian) const;
-    void writeString(const char* pcSrcData, uint32_t uiOffset);
-    void readString(char* pcDstData, uint32_t uiOffset) const;
+    void writeString(const std::string &input, uint32_t uiOffset);
+    void readString(std::string &output, uint32_t uiOffset) const;
 
     // Access from/to subsystems
     uint8_t* getLocation(uint32_t uiOffset);