diff options
| author | Sebastien Gonzalve <sebastien.gonzalve@intel.com> | 2013-03-12 14:30:27 +0100 |
|---|---|---|
| committer | David Wagner <david.wagner@intel.com> | 2014-02-12 17:03:56 +0100 |
| commit | d7e4844d85db591a2ea235dd1b081c76e2f5cb9d (patch) | |
| tree | 0fbd5a53da81d69d8e43739777016b9391a5b3e0 /xmlserializer | |
| parent | a4c39f1a12cad5239c92387eef26d1d3b38f3a43 (diff) | |
| download | external_parameter-framework-d7e4844d85db591a2ea235dd1b081c76e2f5cb9d.zip external_parameter-framework-d7e4844d85db591a2ea235dd1b081c76e2f5cb9d.tar.gz external_parameter-framework-d7e4844d85db591a2ea235dd1b081c76e2f5cb9d.tar.bz2 | |
Remove no-non-virtual-dtor flag
BZ: 111473
The warning non-virtual-dtor should not be ignored for the whole project, but
only in the few cases where it it necessary.
Change-Id: I0ede82a30f2cd055b789f7fb56104fb227934e6f
Signed-off-by: Sebastien Gonzalve <sebastien.gonzalve@intel.com>
Signed-off-by: Guilhem IMBERTON <guilhem.imberton@intel.com>
Reviewed-on: http://android.intel.com:8080/110191
Reviewed-by: buildbot <buildbot@intel.com>
Tested-by: buildbot <buildbot@intel.com>
Diffstat (limited to 'xmlserializer')
| -rw-r--r-- | xmlserializer/Android.mk | 2 | ||||
| -rw-r--r-- | xmlserializer/XmlDocSink.h | 1 | ||||
| -rw-r--r-- | xmlserializer/XmlSink.h | 3 | ||||
| -rw-r--r-- | xmlserializer/XmlSource.h | 3 |
4 files changed, 7 insertions, 2 deletions
diff --git a/xmlserializer/Android.mk b/xmlserializer/Android.mk index 6d2770c..8ddb700 100644 --- a/xmlserializer/Android.mk +++ b/xmlserializer/Android.mk @@ -18,8 +18,6 @@ COMMON_MODULE := libxmlserializer COMMON_MODULE_TAGS := optional -COMMON_CFLAGS := -Wno-non-virtual-dtor - COMMON_C_INCLUDES := \ external/libxml2/include/ \ external/webkit/Source/WebCore/icu/ \ diff --git a/xmlserializer/XmlDocSink.h b/xmlserializer/XmlDocSink.h index e1b2fc3..d341ecf 100644 --- a/xmlserializer/XmlDocSink.h +++ b/xmlserializer/XmlDocSink.h @@ -34,6 +34,7 @@ public: // Source processing bool process(CXmlDocSource& xmlDocSource, CXmlSerializingContext& serializingContext); + virtual ~CXmlDocSink() {} private: // Handle for subclasses to process the source diff --git a/xmlserializer/XmlSink.h b/xmlserializer/XmlSink.h index 0d09a1d..dfa0686 100644 --- a/xmlserializer/XmlSink.h +++ b/xmlserializer/XmlSink.h @@ -31,4 +31,7 @@ class IXmlSink { public: virtual bool fromXml(const CXmlElement& xmlElement, CXmlSerializingContext& serializingContext) = 0; + +protected: + virtual ~IXmlSink() {} }; diff --git a/xmlserializer/XmlSource.h b/xmlserializer/XmlSource.h index 818298d..1a7c52e 100644 --- a/xmlserializer/XmlSource.h +++ b/xmlserializer/XmlSource.h @@ -31,4 +31,7 @@ class IXmlSource { public: virtual void toXml(CXmlElement& xmlElement, CXmlSerializingContext& serializingContext) const = 0; + +protected: + virtual ~IXmlSource() {} }; |