| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
- More details in the root README.md file; add a nice diagram
- Add a lot of README files in subdirectories
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|\
| |
| | |
Realign from internal tree
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
BZ: 207083
License headers were missing in CMake makefiles.
This patch adds the 3-clause BSD license header to each CMakeLists.txt.
Change-Id: Ia4da92e139e02d6348d655d0d88a16166d8431ca
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 207083
According to libstlport.mk, to use stlport for a given target, we shall
"include external/stlport/libstlport.mk" in the target.
This was not done in the parameter-framework's makefiles.
This patch change all targets which require stlport to include it in the
correct way.
Change-Id: Ie9b75af6269f172ad6a6c753e15efd0c7baafdd9
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|\
| |
| | |
Xml validator script
|
|/
|
|
|
|
|
|
|
|
|
|
| |
This tool can be used to validate a set of xml files against w3c
schemas.
It scans a directory recursively and checks for .xml files in it.
For each file, it extracts the current schema file based on a convention
(the corresponding schema file must have the same name as the root node)
which is used in the parameter-framework.
Change-Id: I27e32028e39a450ed18f86cb095348f73d59ade5
|
|\
| |
| | |
Added cmake rules for installing tools in bin dir
|
|/
|
|
|
|
|
|
|
| |
When performing the tutorials, I wanted to use the
tools/xmlGenerator/hostDomainGenerator.sh script.
In order to do that, i had to copy manually my scripts files
to the pfwInstalledDir/bin directory.
This patchs completes the install target by copying the needed files
|
|\
| |
| | |
Help messages
|
| |
| |
| |
| |
| |
| |
| | |
For new users, it was not very clear that you had
to give an .xml to the test-platform executable
This patch implements -h an explicits that
|
| |\ |
|
| | |
| | |
| | |
| | |
| | |
| | | |
New users should be aware of the existence
of the "help" command when they try the
pfw for their first time
|
|\ \ \
| | | |
| | | | |
Skeleton plugin fixes
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
As a new pfw plugin developer, i encountered an undocumented
(in the plugin) naming issue related to how the pfw
loads subsystem builders.
This patchs just added a comment to inform other
developers not to make the same mistake
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The system class convention needs the get<TYPE>SubsystemBuilder
function to have type in caps lock, otherwise the
pfw will loop infinitely when attempting to load plugin.
|
| | |/
| |/| |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We have forgotten to update the list of headers to be installed after some
recent developments.
Change-Id: Iaeadde5bd566021e9ee34c5fd49f3649f1509e3e
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|\ \ \
| |/ /
|/| | |
Realign from internal tree
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 203091
Hard coded relative or absolute paths shall be avoided.
To allow other components to import necessary headers we created two new targets.
Change-Id: I95e8f13765537f431f5730a7cdde4f85f4b7d06a
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 189941
There is an issue when trying to set parameter value in a
configuration using the setConfigurationParameter command.
The error returned is "Unable to forward synchronize
configurable element, Failed to write value in mixer control".
The root cause is a recent update concerning the
auto synchronization mode which is now turned on by default.
The setConfigurationParameter command first updates the local
Configuration blackboard, and then the Main blackboard if this
Configuration is the one applicable for the domain. However,
this local blackboard should not be synchronized, only the
main blackboard should be. This patch deactivates synchronization
for the local blackboard.
Change-Id: I7ca71806309d19ae482399f474d32a0c1b70ae6c
Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 192861
When hostDomainGenerator.sh is called by the build system, it needs to
copy schema files to /tmp/tmp.XXXXXXX. This is because
parameter-framework needs to have the schema files next to the .xml
files in order to apply validation.
In order to do that, hostDomainGenerator.sh needs to know where he can
copy the .xsd files from.
Currently, the .xsd files are copied from
$HOST_OUT/etc/parameter-framework/Schemas via a dedicated makefile.
This used a phony package to group all the files that have to be copied.
The problem is that phony packages the phony package is not calling the
prebuildt rules we need. So the files we want to export to
/etc/parameter-framework/Schemas are not copied.
This patch removes the phony package in order to produce the expected
behaviour.
Change-Id: I96da56f85a8c3d512fcfb97244181dc6c1cb9401
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 192861
The makefile contained a lot of redundancy regarding the source files.
This patch reorders some variables and uses a less error prone way to
declare the LOCAL_SRC_FILES variable by avoiding the repeat of the source files.
Change-Id: Idfff93ef4a9d4aff91d2bc864abf38bf904df685
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 197723
This python script performs several checks on fixed point parameters:
- Bound check: Can we set a value?
- Sanity check: If we get this previously set parameter, is the
value approximately the same? There should be at maximum a
quantum difference between the original value and the returned value.
- Consistency check: Can we set the value we got from the sanity check?
- Bijectivity check: If we get the parameter we set a second time,
is the result the same as the value we got from the set we did in the
Sanity check?
Change-Id: I7b4d61ec740139b0ee70a44b6b38009507a569ee
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 197723
This contains the configuration files which contains a lot of fixedpoint
parameters which can be used for testing.
Change-Id: I261120d16eb6f4d28b6b61a5b2845f1fdc18e91f
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 197723
Give a few functions more meaningful names.
Add some cast fixes and doxygen to the renamed functions.
Change-Id: I002a3fa9b397294153c23b9883c3ad3b1c136e54
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 197723
When adding parameters which are far out of bounds, the range check does
not refuse to set the value. This is unexpected behaviour.
This patch adds a correct range check.
Change-Id: I325920bcabc9485bd8f95aadcaff36a67182b97c
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 197723
Significant digits were computed in order to prevent odd behaviour when printing
a converted fixed point parameter. After converting a number from fixed
point towards a double, we had to round up/down in order to print the
double to the user (or towards a file).
The printing showed only the significant digits, in other words, the
digits which can vary from 0 to 9. This caused unpredictable behaviour
when rounding using the setPrecision() function.
This patch removes the 'precision' notion related to fixed points in
order to have a predictable behaviour by displaying all fractional
digits.
Change-Id: Id5a9b5b8a80d5a96bcbbb6af9213770a05a70083
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 190038
Client disconnection during message reception is normal if no part of the
message as been receive yet.
Client disconnection in the middle of a packet reception is not normal
but was not differentiated from the behaviour described above.
Do not consider client disconnection on first read as an error.
Consider it as an error on the followings.
Change-Id: I34b50ba0af800f9e1fcdb51996b1b2f02a23cb3f
Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 190038
Remote processor was not displaying information in case of network
read/write error.
Add some error messages to ease debug.
Change-Id: I465062e8cf77f94b3d4d4d0c71338c4630aac276
Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 190038
EINTR is a normal error and should not fail recv or send.
Continue if those errors are received.
Change-Id: I66416153eb432b8f7daf97119c7c59c87e88da08
Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 190038
Send can return a 0 size, it is normal.
Does not consider send return value 0 as an error.
Change-Id: Ic4801908b0771d5e0aba8c090fb9e9949d6e16fc
Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 185336
Convert is failing when trying to convert the string value
to integer value within FixedPointParameterType class.
This patch fixes the issue by requesting to convert the string
into a signed type.
Change-Id: I77987eb1564292bd6dcdd0da4db52c4b4f92818f
Signed-off-by: Francois Gaffie <francois.gaffie@intel.com>
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 176178
Explain the precision computation (m * log10(2)):
For a Qn.m number, the step between each storable number is 2^(-m).
Hence, on a decimal representation, the Dth digit after the decimal
point can take all possible values (1..9) - meaning that it is
significant - only if
2^(-m) <= 10^(-D)
-m <= log2(10^(-D))
-m <= log10(10^(-D)) / log10(2)
-m <= -D / log10(2)
m * log10(2) >= D
Conversly, the Dth digit can be represented if
D <= m * log10(2)
We add 1 to the precision in order to display the digit right after the last
significant digit. This will lead to oddities such as:
$ setParameter /Test/test/f32_Q8.23 0.1234569
$ getParameter /Test/test/f32_Q8.23
> 0.1234570
but it will avoid modifying raw values when converting from string to Q-format
and back to string.
Also, use std::setprecision() on the stream instead of manually truncating the
displayed number.
Change-Id: Ief2a7daabf4505ae4312e79036b0374f53368cac
Signed-off-by: David Wagner <david.wagner@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 176178
The isEncodable() method has several prototypes and some compilers are not able
to decide which version to use and produce a compilation error.
Remove unnecessary casts and make the code simpler by using a template-based
conversion library from string to various numeric types instead of using
strtoll and strtod.
Change-Id: I53d0b4ebd12f2cbb315bb52d98365a35876b5aef
Signed-off-by: David Wagner <david.wagner@intel.com>
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 188323
In order to validate xml files, we need the corresponding schemas to be
next to the xml files. Those are put by the script in /tmp.
This patch add the copying of the schema files to /tmp.
I also adds an optional command line argument to disable/enable validation.
This is useful for platform specific enabling/disabling validation.
It can be used by calling hostDomainGenerator.sh --validate.
Change-Id: I7da65f230e5abf5b1d18c5cd6cf11b67dae5ed76
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 188323
For schema validation features, we are using a special version of libxml2 called
libxml2-schemas (which contains the SCHEMAS feature).
This is just a different static library build with that feature only for
the parameter-framework.
The problem with that, is that the include/xmlversion.h does not
define the #LIBXML_SCHEMAS_ENABLED flag.
So when including it in our project, the flag is not defined.
This results in unexpected behaviour since validation was active in the
static library, but never called because the flag was not defined.
As a fix, we are defining the LIBXML_SCHEMAS_ENABLED flag in the makefile.
Change-Id: Id56ae5b668e587171b11e7607f2603ab5e3341a1
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 188323
In order to validate the .xml parameter framework files, we use XSDs.
Those must be in the same directory as the .xml files when they
are validated.
This patch copies the .xsd files towards a directory that
hostDomainGenerator knows, so that he can use the files and
copy them towards /tmp.
Change-Id: I938fc3791006777ff65c96d4259596111f93d7b8
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 189977
The hostDomainGenerator.sh script generates xml files a build time.
Sometimes it fails but the log information are no sufficient to found
the root cause.
Add some log information in order to be able to find it.
Change-Id: I505577ee30503dccf25375b0ea262461ec4cce14
Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 186081
Due to upgrade klocwork (KW version from 9.6 to 10.0)
new issues have been raised.
This patch fix the new issues raised in PFW.
Change-Id: I54c14e4d6da1c9a5f8d82aec1769a9e7e948db50
Signed-off-by: Eduardo Mendi <eduardox.mendi@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 184054
test-platform has no way to tell to the parameter
framework that it wants the parameter framework to
validate xmls on loading.
New command added to test-platform executable.
setValidateSchemasOnStart true|false
If set to true, the parameter framework will try
to validate the .xmls with the .xsds located next to them.
If set to false, it will never attempt to validate.
SetValidateSchemas is false by default to allow backward compatibility.
Note(a): This assumes that the script is able to
find the .xsd files (which should be in /tmp/Schemas/).
Change-Id: I7a5b0bc09d31e6647d8c631380d31503666e7e7b
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 184054
It was not possible to enable/disable xml file validation.
The parameter framework only relied on the LIBXML_SCHEMAS flag.
This patchs implements a new constructor for XmlFiles
which allows enabling/disabling xml/xsd check.
Change-Id: I32d220a42bb27f4ce685f07cb194e78e76f44a5d
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The "Schema" feature is enabled in the official libxml2.
We use that feature to validate the xml files given to the
parameter-framework.
In the libxml2 aosp version, this feature is not enabled.
This patch adds a new target, libxml2-schemas, which contains the
"Schemas" feature.
This should be removed when the "Schema" feature is integrated into the
aosp's libxml2 version.
Change-Id: Ida72de36e7fd196063a332ee70b30c0f0cb69024
Signed-off-by: David Wagner <david.wagner@intel.com>
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 184054
In order to verify that xml files are valid, the parameter framework
check them with .xsd files.
In those files, there are references towards base schemas on the
internet. Which means that every validation downloads a copy of
the base file via http.
To avoid doing http requests, we can use the file locally.
This patchs changes from remote file to local.
Change-Id: Ide48dba0000db7c97e1d269ee5573ac8afe7e4d4
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 183857
Explicit API names makes the code easier to read, allowing even
to remove some comments.
This patch adds an API to append the parameter path to the error log.
Change-Id: Id136497072e53c8dd0ea3d95354e1dfe6193f771
Signed-off-by: Francois Gaffie <francois.gaffie@intel.com>
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 183857
Sync for String parameter accessed from parameter handle API
does not work.
This patch allows synchronisation for string parameter accessed
from parameter handle APIs.
Change-Id: If738402f4c0fcb0bb51bd2515e46f3ac36a361dd
Signed-off-by: Francois Gaffie <francois.gaffie@intel.com>
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 176942
Add a class (ConfigurableMappingElement) handling the mapping; to be derived by
all classes that can contain mapping. ConfigurableMappingElement derives from
ConfigurableElement. Until now, the only child of ConfigurableElement that
could have mapping was InstanceConfigurableElement (through TypeElement, that
contains all information related to its type).
Now, both InstanceConfigurableElement and Subsystem derive from
ConfigurableMappingElement. That way, Subsystem XML elements can now have a
"Mapping" attribute, propagated to all Elements in the tree. The Subsystem.xsd
schema is updated in that regard.
Only context mapping is relevant at the Subsystem-level (as opposed to
instantiation mapping). If an instantiation mapping is set in the Subsystem,
it is silently ignored.
Change-Id: I3c09959bc5e3d18c5a4d354e498d69cc5489a247
Signed-off-by: David Wagner <david.wagner@intel.com>
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 177060
When the initial XML file for tuning is too big, the XML generation
fails with the message: "Argument list too long". This is because the
generation relies on the PFW command "setDomainsWithSettingsXML", which
takes XML data as string argument. There is a limitation concerning
the size of this string, leading to the current issue.
This patch replaces the call to "setDomainsWithSettingsXML" by
"importDomainsWithSettingsXML", which takes a file as argument instead
of a string. There is no limitation on the file size.
Change-Id: Ieb12e6ba1391545021cd3f1e867dee0d28425d19
Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BZ: 171573
If localhost is not bound to 127.0.0.1, socket creation fails in the
portAllocator.py script. This error is not well catched in the main
tool hostDomainGenerator.sh.
This patch updates portAllocator.py so that the IP address 127.0.0.1
is used instead of localhost. In addition, the potential error messages
raised by portAllocator.py are now correctly taken into account by
hostDomainGenerator.sh. HostDomainGenerator.sh has also been updated
to replace all instances of 'localhost' by '127.0.0.1'.
Change-Id: I7ed6ede7a1148360efac4bf38f49054066a50a29
Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com>
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 34e90ae1c744e1de6547e014326ef54f516439c8.
libparameter_includes and libparameter_includes_host are used to build
the parameter-framework plugins. They were removed by error.
We need to revert this patch since we still use those make targets.
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|\ \
| |/
|/| |
Add an example skeleton plugin
|