| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
- More details in the root README.md file; add a nice diagram
- Add a lot of README files in subdirectories
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 207083
License headers were missing in CMake makefiles.
This patch adds the 3-clause BSD license header to each CMakeLists.txt.
Change-Id: Ia4da92e139e02d6348d655d0d88a16166d8431ca
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 207083
According to libstlport.mk, to use stlport for a given target, we shall
"include external/stlport/libstlport.mk" in the target.
This was not done in the parameter-framework's makefiles.
This patch change all targets which require stlport to include it in the
correct way.
Change-Id: Ie9b75af6269f172ad6a6c753e15efd0c7baafdd9
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
| |
We have forgotten to update the list of headers to be installed after some
recent developments.
Change-Id: Iaeadde5bd566021e9ee34c5fd49f3649f1509e3e
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 189941
There is an issue when trying to set parameter value in a
configuration using the setConfigurationParameter command.
The error returned is "Unable to forward synchronize
configurable element, Failed to write value in mixer control".
The root cause is a recent update concerning the
auto synchronization mode which is now turned on by default.
The setConfigurationParameter command first updates the local
Configuration blackboard, and then the Main blackboard if this
Configuration is the one applicable for the domain. However,
this local blackboard should not be synchronized, only the
main blackboard should be. This patch deactivates synchronization
for the local blackboard.
Change-Id: I7ca71806309d19ae482399f474d32a0c1b70ae6c
Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com>
|
|
|
|
|
|
|
|
|
|
| |
BZ: 197723
Give a few functions more meaningful names.
Add some cast fixes and doxygen to the renamed functions.
Change-Id: I002a3fa9b397294153c23b9883c3ad3b1c136e54
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 197723
When adding parameters which are far out of bounds, the range check does
not refuse to set the value. This is unexpected behaviour.
This patch adds a correct range check.
Change-Id: I325920bcabc9485bd8f95aadcaff36a67182b97c
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 197723
Significant digits were computed in order to prevent odd behaviour when printing
a converted fixed point parameter. After converting a number from fixed
point towards a double, we had to round up/down in order to print the
double to the user (or towards a file).
The printing showed only the significant digits, in other words, the
digits which can vary from 0 to 9. This caused unpredictable behaviour
when rounding using the setPrecision() function.
This patch removes the 'precision' notion related to fixed points in
order to have a predictable behaviour by displaying all fractional
digits.
Change-Id: Id5a9b5b8a80d5a96bcbbb6af9213770a05a70083
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 185336
Convert is failing when trying to convert the string value
to integer value within FixedPointParameterType class.
This patch fixes the issue by requesting to convert the string
into a signed type.
Change-Id: I77987eb1564292bd6dcdd0da4db52c4b4f92818f
Signed-off-by: Francois Gaffie <francois.gaffie@intel.com>
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 176178
Explain the precision computation (m * log10(2)):
For a Qn.m number, the step between each storable number is 2^(-m).
Hence, on a decimal representation, the Dth digit after the decimal
point can take all possible values (1..9) - meaning that it is
significant - only if
2^(-m) <= 10^(-D)
-m <= log2(10^(-D))
-m <= log10(10^(-D)) / log10(2)
-m <= -D / log10(2)
m * log10(2) >= D
Conversly, the Dth digit can be represented if
D <= m * log10(2)
We add 1 to the precision in order to display the digit right after the last
significant digit. This will lead to oddities such as:
$ setParameter /Test/test/f32_Q8.23 0.1234569
$ getParameter /Test/test/f32_Q8.23
> 0.1234570
but it will avoid modifying raw values when converting from string to Q-format
and back to string.
Also, use std::setprecision() on the stream instead of manually truncating the
displayed number.
Change-Id: Ief2a7daabf4505ae4312e79036b0374f53368cac
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 176178
The isEncodable() method has several prototypes and some compilers are not able
to decide which version to use and produce a compilation error.
Remove unnecessary casts and make the code simpler by using a template-based
conversion library from string to various numeric types instead of using
strtoll and strtod.
Change-Id: I53d0b4ebd12f2cbb315bb52d98365a35876b5aef
Signed-off-by: David Wagner <david.wagner@intel.com>
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 186081
Due to upgrade klocwork (KW version from 9.6 to 10.0)
new issues have been raised.
This patch fix the new issues raised in PFW.
Change-Id: I54c14e4d6da1c9a5f8d82aec1769a9e7e948db50
Signed-off-by: Eduardo Mendi <eduardox.mendi@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 184054
test-platform has no way to tell to the parameter
framework that it wants the parameter framework to
validate xmls on loading.
New command added to test-platform executable.
setValidateSchemasOnStart true|false
If set to true, the parameter framework will try
to validate the .xmls with the .xsds located next to them.
If set to false, it will never attempt to validate.
SetValidateSchemas is false by default to allow backward compatibility.
Note(a): This assumes that the script is able to
find the .xsd files (which should be in /tmp/Schemas/).
Change-Id: I7a5b0bc09d31e6647d8c631380d31503666e7e7b
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 183857
Explicit API names makes the code easier to read, allowing even
to remove some comments.
This patch adds an API to append the parameter path to the error log.
Change-Id: Id136497072e53c8dd0ea3d95354e1dfe6193f771
Signed-off-by: Francois Gaffie <francois.gaffie@intel.com>
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 183857
Sync for String parameter accessed from parameter handle API
does not work.
This patch allows synchronisation for string parameter accessed
from parameter handle APIs.
Change-Id: If738402f4c0fcb0bb51bd2515e46f3ac36a361dd
Signed-off-by: Francois Gaffie <francois.gaffie@intel.com>
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 176942
Add a class (ConfigurableMappingElement) handling the mapping; to be derived by
all classes that can contain mapping. ConfigurableMappingElement derives from
ConfigurableElement. Until now, the only child of ConfigurableElement that
could have mapping was InstanceConfigurableElement (through TypeElement, that
contains all information related to its type).
Now, both InstanceConfigurableElement and Subsystem derive from
ConfigurableMappingElement. That way, Subsystem XML elements can now have a
"Mapping" attribute, propagated to all Elements in the tree. The Subsystem.xsd
schema is updated in that regard.
Only context mapping is relevant at the Subsystem-level (as opposed to
instantiation mapping). If an instantiation mapping is set in the Subsystem,
it is silently ignored.
Change-Id: I3c09959bc5e3d18c5a4d354e498d69cc5489a247
Signed-off-by: David Wagner <david.wagner@intel.com>
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 34e90ae1c744e1de6547e014326ef54f516439c8.
libparameter_includes and libparameter_includes_host are used to build
the parameter-framework plugins. They were removed by error.
We need to revert this patch since we still use those make targets.
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
|
| |
client headers are exporter in parameter/client; plugin headers in
parameter/plugin.
Also, reduce the list of exported plugin headers to the bare minimum.
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
|
| |
libparameter abd libxmlserializer headers.
Concerning libparameter headers: only core headers (needed for the plugins) are
currently exported. We'll need to export the client headers too, but we must
make a distiction between the two classes of headers. Also, some currently
exported core headers might not be needed (some cleanup is needed).
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
| |
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
| |
It is accessed through dlopen().
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
| |
Run "cmake -DCMAKE_INSTALL_PREFIX=/path/to/install ." for choosing a custom
prefix (optional: if it is not specified, a default directory will be chosen).
Run "make install" for installing all generated files.
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
| |
1) Generate the Makefiles with "cmake";
2) compile all targets with "make".
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
| |
The plugins' Android.mk will directly access libparameter's include dir.
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
| |
That name was too generic and may have conflicted in the future.
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
| |
Pathmaps for libxml2, stlport and icu4c are not defined in vanilla AOSP.
As temporary fix for compilation on vanilla AOSP, we need to hardcode them
again. Commit 55f41bcc3edf282f236539bb26bd6dc8638f235e introduced the use of
include-path-for.
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
| |
Add license header in all source files and Makefiles,
Add a "COPYING" file containing the license text.
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 168727
In the PFW structure file, it is not possible to include a component
library from another XML file.
Implement the possibility to import component from another XML file
that would be included in a structure XML file and that would
describe a component library.
Change-Id: Id6125140de1c8e9882375d01199f695b929f45e2
Signed-off-by: Guillaume Denneulin <guillaume.denneulin@intel.com>
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 165527
PFW does not convert hexadecimal signed range values correctly
This patch correct signed range values interpretation
Change-Id: I5c060c637781821b70b769cabc31347b0e5e5be1
Signed-off-by: Sylvain Pichon <sylvainx.pichon@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 163707
When using signed integers of size 8 or 16, the bit of sign needs to
be propagated if the API called by the plugin wait for "int" type
Add the virtual toInteger function in CTypeElement for each parameter
type to take care of conversion to "int". Specialize this function in
the class CIntegerParameterType to take care of sign extension.
Change-Id: I41183dccbcc21212299d1dde86b3ad4ba8432ce4
Signed-off-by: Guillaume Denneulin <guillaume.denneulin@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 151780
Debugging XML generation from .pfw files is uneasy because the
log messages are lacking ports & sockets information.
Added the port number to the logs of the PFW when a new socket
is created.
Change-Id: I688f954068a6819ecc9e65f7664ac7a98ca0dabf
Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com>
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 154623
When logging, the pfw was limited to 512 bytes.
Remove this limitation and optimize the buffer allocated.
Change-Id: I91537f30a519d93a4b1e55a23fe02f42dec3af8a
Signed-off-by: Guillaume Denneulin <guillaume.denneulin@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 159294
The PFW opens many dynamic libs but does not keep any track of them.
This prevents to close them cleanly and have border effect when trying
to do coverage measurement.
The patch ensures that the PFW closes its libraries when destroyed.
Change-Id: Idd1f69bfbc719e8e000914bef990c809ec5ed206
Signed-off-by: Renaud de Chivre <renaud.de.chivre@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 156207
When an error occurs while using a path one does not know which path it
refers to.
Append the unfound path to the error : "Path not found:
/the/path/that/was/not/found"
Change-Id: If53c1a5c301906b464d38f604d6e97029f83ae3f
Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 156675
Plugins are moving to new repositories.
Modify include handling to comply inter-repo include dependency.
Change-Id: I4f65ab4a7f1f524b59dffc567a679154e3394147
Signed-off-by: Guillaume Denneulin <guillaume.denneulin@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 99956
Inclusive criterion type does not allow to check if the bitfield
is empty, i.e., if zero is not available.
This patch adds the default value pair "none, 0" to allow
check either if the criterion "Is" 0, and establishes consistency
with inclusion rule. It also allows to convert a concatenated
chain of string value, where "|" is considered as AND rule into
the corresponding numerical value.
Change-Id: I4ee7c0f69228a727964ab80050ac12c6babd4f58
Signed-off-by: Francois Gaffie <francois.gaffie@intel.com>
Signed-off-by: Jorge Quintero <jorge.quintero@intel.com>
Reviewed-on: http://android.intel.com:8080/138518
Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com>
Tested-by: Barthes, FabienX <fabienx.barthes@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 99956
Bitfield parameter type does not allow to retrieve the position
of the bit.
This patch introduces a new API to retrieve the bit position in the
bitfield
Change-Id: I54bf8a446e7bd53bed6acda274d32966a737c877
Signed-off-by: Francois Gaffie <francois.gaffie@intel.com>
Reviewed-on: http://android.intel.com:8080/138517
Reviewed-by: Quintero, Jorge <jorge.quintero@intel.com>
Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com>
Tested-by: Barthes, FabienX <fabienx.barthes@intel.com>
Reviewed-by: Balestriere, VianneyX <vianneyx.balestriere@intel.com>
Tested-by: Balestriere, VianneyX <vianneyx.balestriere@intel.com>
|
|
|
|
|
|
|
| |
host version of lib libicuuc has changed to libicuuc-host
Change-Id: I936a8e196d01d8cacf4ce0d64370b9cddccd8b3a
Signed-off-by: Jin Wei <wei.a.jin@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 151782
There is a typo in the error message when a plugin is not found
(folowings instead of following).
This patch updates the error message.
Change-Id: Ifdb749fd90d646d0c04522874e879a329520de0f
Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 134249
The behavior is undefined in the case of signed integer overflow
for enum and fixed point parameter types.
Modify the behavior to handle correctly the signed integers.
Change-Id: Idbd0798a39f826853ae1afcd05cebd897675b9a8
Signed-off-by: Dmitry Shkurko <Dmitry.V.Shkurko@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 147490
Components did not support instantiation mapping (mapping that
instantiate subsystem objects) which leaded to artificial parameter bloc
use, ie a useless level.
Treat the components as parameter block as for instantiation mappings.
Change-Id: I64834dbdcbda9ab32a29d6c70dc12da5b5fe6d35
Signed-off-by: Georges-Henri Baron <georges-henrix.baron@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 126002
Mapping context only allows to retrieve a mapping value from its
corresponding key ID. We also want to do the same using its key
as a string.
This patch adds key name handling in context mapping. It also adds
an API to retieve a mapping value from its corresponding key name.
Note: it also removes an unused argument from handleMappingContext
function.
Change-Id: I5a18ad624a69272ea2796090692f2bfa8b373a52
Signed-off-by: Renaud de Chivre <renaud.de.chivre@intel.com>
Reviewed-on: http://android.intel.com:8080/131571
Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com>
Reviewed-by: cactus <cactus@intel.com>
Tested-by: cactus <cactus@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 126002
Host build is used for testing and debugging purpose.
It shall contain debug symbols and shall no be optimized.
This patch add required compilation flags to achieve this.
Change-Id: I6dec6166ca4c705a3ccc7a9ddd6f5a955a91f910
Signed-off-by: Renaud de Chivre <renaud.de.chivre@intel.com>
Reviewed-on: http://android.intel.com:8080/131570
Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com>
Reviewed-by: cactus <cactus@intel.com>
Tested-by: cactus <cactus@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 122982
When the PFW starts it loads the configurable domains, if the load
fails, it used to abort the parameterMgr global load.
Add an option to continue on failed setting load, as if there were none.
Change-Id: Ifd3cd859ad0eaef266be4c9245ebd28c9e9c0a74
Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
Reviewed-on: http://android.intel.com:8080/119924
Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com>
Tested-by: Barthes, FabienX <fabienx.barthes@intel.com>
Reviewed-by: cactus <cactus@intel.com>
Tested-by: cactus <cactus@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 122982
When the PFW starts it loads subsystems using there corresponding
plugin. If the requested plugin is not found, the start fails. This is a
problem, as for host, the plugins are not compiled.
Add a command in the public API to ignore missing subsystem.
Change-Id: I7597e3fef33466638191ff70b76e7faa9f979418
Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
Reviewed-on: http://android.intel.com:8080/118039
Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com>
Tested-by: Barthes, FabienX <fabienx.barthes@intel.com>
Reviewed-by: cactus <cactus@intel.com>
Tested-by: cactus <cactus@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 122982
The CSystemClass::loadSubsystems was too long.
Create a subfunction to load subsystems defined in shared libraries.
Change-Id: I8f40ee271f25d0996e1976d8ee2ef6c12581d1d4
Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
Reviewed-on: http://android.intel.com:8080/118192
Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com>
Tested-by: Barthes, FabienX <fabienx.barthes@intel.com>
Reviewed-by: cactus <cactus@intel.com>
Tested-by: cactus <cactus@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 122982
When the PFW starts, it loads subsystems using their corresponding
plugins. If a requested plugin is not found, the start fails. This is a
problem, as for host, plugins are not compiled.
Add an option to fallback on virtual subsystem if a plugin is not found
during load.
Change-Id: Id408873fdc904612c0c741524b33025d7d199fe9
Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
Reviewed-on: http://android.intel.com:8080/117709
Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com>
Tested-by: Barthes, FabienX <fabienx.barthes@intel.com>
Reviewed-by: cactus <cactus@intel.com>
Tested-by: cactus <cactus@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 122982
The element library class is a factory that receives an xml node and
instanciates the corresponding element. In some case, it would be usefull
not to fail if no matching builder is found but use a default one.
Add a setDefaultElementBuilder method to set the default builder to
fallback to, in case no matching builder is found.
Change-Id: I58f0ada3450195a3ca7d878e4b666b0a9359b499
Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
Reviewed-on: http://android.intel.com:8080/118042
Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com>
Tested-by: Barthes, FabienX <fabienx.barthes@intel.com>
Reviewed-by: cactus <cactus@intel.com>
Tested-by: cactus <cactus@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 122982
To parse XML, the PFW uses factories containing a map of XML tags and
their associated builder builder. The builders used to contain the XML
tag of the XML element that it will use in the context of the factory.
A builder and an XML tag are already linked by the factory, thus the tag
member in the builder is redundant.
Remove the XML tag builder attribute and provide it on factory filling.
Change-Id: I827c3b34dffb23bc850316d0b092b31c21987ac2
Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
Reviewed-on: http://android.intel.com:8080/124214
Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com>
Tested-by: Barthes, FabienX <fabienx.barthes@intel.com>
Reviewed-by: cactus <cactus@intel.com>
Tested-by: cactus <cactus@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 127874
Default entry point for plugins libraries must follow the pattern
"lib*-subsystem.so". However, when compiling on host, the plugins
are named "lib*-subsystem_host.so", so the PFW is unable to load
them.
This patch modifies the way plugins symbols are detected, so that
host libraries can be loaded successfully.
Change-Id: I079162c3e47a975641b3d7cb1fc054f95c86028e
Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com>
Reviewed-on: http://android.intel.com:8080/122812
Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com>
Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com>
Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com>
Reviewed-by: cactus <cactus@intel.com>
Tested-by: cactus <cactus@intel.com>
|