| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The command is used as follows:
importDomainWithSettingsXML <file path> [overwrite]
It reads the file given as first argument (path must be absolute) and imports
the domain found in it.
It does not check whether it overlaps with another domain (same elements in two
domains). It does, however, check if there is an existing domain with the same
name as the one being imported. If so and if the (optional) second argument
is "overwrite", it will first delete the existing domain; if not it will refuse
to import the new domain.
Change-Id: I7aaa225f2f1a296f52dc8a97f55e1ff70c06d567
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The command is used as follows:
getDomainWithSettingsXML <domain>
and outputs the requested domain to the standard output.
In that end, the const version of CConfigurableDomains::findConfigurableDomain
is made public. This somewhat breaks encapsulation but since the returned
domain is const, this has limited impact.
Change-Id: I9b854040a5d59913b9b405c8e38d29a3018a6079
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
| |
This allows diminishing the dependency on the parent element when creating a
Domain element from an XML document: the parent was used to get a handle to the
system class in order to check the existence of ConfigurableElements included
in the Domain.
Change-Id: Icba7c3c4db2b9728c0fb7c6840a254de9775f6a4
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Import and Export of ConfigurableDomains have different context needs: e.g. the
value representation is only used for export; auto-validation is only
meaningful for import whereas the "with settings" context is common to both.
We create two new classes, derived from XmlDomainSerializingContext and move
most of its content to each class it belongs to.
Change-Id: I56589cdb3a8ea417e11d2ed98ccd055d7cdead67
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
| |
Implement the non-const method of findConfigurableDomain by calling the const
version, as described in Effective C++ Item 3.
Change-Id: Ib7b58100dc817d02092299923edf2e6c7ce2f117
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The toXml method has a default implementation that recursively calls toXml on
the children and set their "Name" attribute.
With this approach, the toplevel element's name isn't set unless its overrided
implementation explicitly does so.
A first approach for fixing that is to set the XmlElement's name and
recursively call toXml on children (without setting their name because it will
be done by their toXml method). However, the "CXmlElement" being created may or
may not be the object on which the toXml method is called, in which case the
name will be set on the wrong XmlElement.
Instead, in CElement::toXml, we set the XmlElement's name and call a new
virtual method, childrenToXml which only recursively call toXml on children.
This gives full flexibility to elements to choose how they want to serialize
themselves and how they want to serialize their children.
CConfigurableDomain::toXml is modified to take that change into account.
Change-Id: Id12a1023e91cb000e55c242c13643b1db7d46871
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
| |
It's been a long time we haven't changed this version number. We will start
making releases and this one is the first of a series.
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|\
| |
| | |
Remove libxml2-schemas target since it is now covered by the aosp
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
BZ: 218524
The "Schemas" feature is enabled in Android-L,
so there is no need for this out-of-tree compilation
anymore.
So this patch deletes its compilation in
parameter-framework project.
Change-Id: I111afa3e12fa80c2871bae475d550bc49c4440cc
Signed-off-by: pafonsoX <philippex.afonso@intel.com>
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|/
|
|
|
|
|
|
|
|
|
|
|
| |
This error happens, among others, when trying to set an element as if it was a
parameter. The error message was not very helpful.
Previous error message:
Non accessible element
New error message:
Can't set /A/b/c because it is not a parameter
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|\
| |
| | |
Fix a use-after-free issue
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In CBinaryStream, a member gets used after it has been destroyed. This was
caught by a static code analyser.
Issue: GMINL-1702
Change-Id: I5c93855f12a8f392e1f4249a15048816fb0f13ce
Signed-off-by: David Wagner <david.wagner@intel.com>
Reviewed-on: https://android.intel.com/278483
Reviewed-by: cactus <cactus@intel.com>
Tested-by: cactus <cactus@intel.com>
Reviewed-by: Beatty, Robert M <robert.m.beatty@intel.com>
Tested-by: Beatty, Robert M <robert.m.beatty@intel.com>
|
|\ \
| | |
| | | |
Remove non ascii char
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Some comments representing a file tree were
using non ASCII characters.
They are not readable on many editors leading to
incoherent display.
Replace them by plain ASCII characters.
Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
|
|\ \
| | |
| | | |
Fix build issues bis
|
| | |
| | |
| | |
| | |
| | |
| | | |
It does not compile yet; this issue will have to be tackled.
Signed-off-by: David Wagner <david.wagner@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This seems to be mandatory.
Change-Id: Idba8c7a3ec9e2f05b28ee593d1d15a420a0bd9ed
Signed-off-by: David Wagner <david.wagner@intel.com>
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
LOCAL_MODULE_PATH is deprecated and in this case, useless.
Change-Id: I72054e3a5c70c2779d170f07f24734d75fdf48f8
Signed-off-by: Qiming Shi <qiming.shi@intel.com>
Reviewed-on: https://android.intel.com/211229
Reviewed-by: cactus <cactus@intel.com>
|
|\ \
| | |
| | | |
some C++ cleanup
|
| | |
| | |
| | |
| | |
| | | |
This is a bad practice to have using in headers because it pollutes the
namespace of any user of that header.
|
| |/
| |
| |
| |
| | |
Those files are empty or almost empty, put remaining stuff in header if
necessary.
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the xml defines the path of plugin library as empty, as a
slash is always added between the folder path and the library name,
the parameter framework will look for the library at the root of the
file system.
This patch prevents from adding the slash except if the path
is not empty.
Issue: GMINL-1748
Change-Id: I14ed5a5ddbef7e0305300479f4fd44bf611f3442
Signed-off-by: Louis Le Gall <louis.le.gall@intel.com>
|
|
|
|
|
|
|
| |
- More details in the root README.md file; add a nice diagram
- Add a lot of README files in subdirectories
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 207083
License headers were missing in CMake makefiles.
This patch adds the 3-clause BSD license header to each CMakeLists.txt.
Change-Id: Ia4da92e139e02d6348d655d0d88a16166d8431ca
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 207083
According to libstlport.mk, to use stlport for a given target, we shall
"include external/stlport/libstlport.mk" in the target.
This was not done in the parameter-framework's makefiles.
This patch change all targets which require stlport to include it in the
correct way.
Change-Id: Ie9b75af6269f172ad6a6c753e15efd0c7baafdd9
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
| |
We have forgotten to update the list of headers to be installed after some
recent developments.
Change-Id: Iaeadde5bd566021e9ee34c5fd49f3649f1509e3e
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 189941
There is an issue when trying to set parameter value in a
configuration using the setConfigurationParameter command.
The error returned is "Unable to forward synchronize
configurable element, Failed to write value in mixer control".
The root cause is a recent update concerning the
auto synchronization mode which is now turned on by default.
The setConfigurationParameter command first updates the local
Configuration blackboard, and then the Main blackboard if this
Configuration is the one applicable for the domain. However,
this local blackboard should not be synchronized, only the
main blackboard should be. This patch deactivates synchronization
for the local blackboard.
Change-Id: I7ca71806309d19ae482399f474d32a0c1b70ae6c
Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com>
|
|
|
|
|
|
|
|
|
|
| |
BZ: 197723
Give a few functions more meaningful names.
Add some cast fixes and doxygen to the renamed functions.
Change-Id: I002a3fa9b397294153c23b9883c3ad3b1c136e54
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 197723
When adding parameters which are far out of bounds, the range check does
not refuse to set the value. This is unexpected behaviour.
This patch adds a correct range check.
Change-Id: I325920bcabc9485bd8f95aadcaff36a67182b97c
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 197723
Significant digits were computed in order to prevent odd behaviour when printing
a converted fixed point parameter. After converting a number from fixed
point towards a double, we had to round up/down in order to print the
double to the user (or towards a file).
The printing showed only the significant digits, in other words, the
digits which can vary from 0 to 9. This caused unpredictable behaviour
when rounding using the setPrecision() function.
This patch removes the 'precision' notion related to fixed points in
order to have a predictable behaviour by displaying all fractional
digits.
Change-Id: Id5a9b5b8a80d5a96bcbbb6af9213770a05a70083
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 185336
Convert is failing when trying to convert the string value
to integer value within FixedPointParameterType class.
This patch fixes the issue by requesting to convert the string
into a signed type.
Change-Id: I77987eb1564292bd6dcdd0da4db52c4b4f92818f
Signed-off-by: Francois Gaffie <francois.gaffie@intel.com>
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 176178
Explain the precision computation (m * log10(2)):
For a Qn.m number, the step between each storable number is 2^(-m).
Hence, on a decimal representation, the Dth digit after the decimal
point can take all possible values (1..9) - meaning that it is
significant - only if
2^(-m) <= 10^(-D)
-m <= log2(10^(-D))
-m <= log10(10^(-D)) / log10(2)
-m <= -D / log10(2)
m * log10(2) >= D
Conversly, the Dth digit can be represented if
D <= m * log10(2)
We add 1 to the precision in order to display the digit right after the last
significant digit. This will lead to oddities such as:
$ setParameter /Test/test/f32_Q8.23 0.1234569
$ getParameter /Test/test/f32_Q8.23
> 0.1234570
but it will avoid modifying raw values when converting from string to Q-format
and back to string.
Also, use std::setprecision() on the stream instead of manually truncating the
displayed number.
Change-Id: Ief2a7daabf4505ae4312e79036b0374f53368cac
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 176178
The isEncodable() method has several prototypes and some compilers are not able
to decide which version to use and produce a compilation error.
Remove unnecessary casts and make the code simpler by using a template-based
conversion library from string to various numeric types instead of using
strtoll and strtod.
Change-Id: I53d0b4ebd12f2cbb315bb52d98365a35876b5aef
Signed-off-by: David Wagner <david.wagner@intel.com>
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 186081
Due to upgrade klocwork (KW version from 9.6 to 10.0)
new issues have been raised.
This patch fix the new issues raised in PFW.
Change-Id: I54c14e4d6da1c9a5f8d82aec1769a9e7e948db50
Signed-off-by: Eduardo Mendi <eduardox.mendi@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 184054
test-platform has no way to tell to the parameter
framework that it wants the parameter framework to
validate xmls on loading.
New command added to test-platform executable.
setValidateSchemasOnStart true|false
If set to true, the parameter framework will try
to validate the .xmls with the .xsds located next to them.
If set to false, it will never attempt to validate.
SetValidateSchemas is false by default to allow backward compatibility.
Note(a): This assumes that the script is able to
find the .xsd files (which should be in /tmp/Schemas/).
Change-Id: I7a5b0bc09d31e6647d8c631380d31503666e7e7b
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 183857
Explicit API names makes the code easier to read, allowing even
to remove some comments.
This patch adds an API to append the parameter path to the error log.
Change-Id: Id136497072e53c8dd0ea3d95354e1dfe6193f771
Signed-off-by: Francois Gaffie <francois.gaffie@intel.com>
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 183857
Sync for String parameter accessed from parameter handle API
does not work.
This patch allows synchronisation for string parameter accessed
from parameter handle APIs.
Change-Id: If738402f4c0fcb0bb51bd2515e46f3ac36a361dd
Signed-off-by: Francois Gaffie <francois.gaffie@intel.com>
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 176942
Add a class (ConfigurableMappingElement) handling the mapping; to be derived by
all classes that can contain mapping. ConfigurableMappingElement derives from
ConfigurableElement. Until now, the only child of ConfigurableElement that
could have mapping was InstanceConfigurableElement (through TypeElement, that
contains all information related to its type).
Now, both InstanceConfigurableElement and Subsystem derive from
ConfigurableMappingElement. That way, Subsystem XML elements can now have a
"Mapping" attribute, propagated to all Elements in the tree. The Subsystem.xsd
schema is updated in that regard.
Only context mapping is relevant at the Subsystem-level (as opposed to
instantiation mapping). If an instantiation mapping is set in the Subsystem,
it is silently ignored.
Change-Id: I3c09959bc5e3d18c5a4d354e498d69cc5489a247
Signed-off-by: David Wagner <david.wagner@intel.com>
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 34e90ae1c744e1de6547e014326ef54f516439c8.
libparameter_includes and libparameter_includes_host are used to build
the parameter-framework plugins. They were removed by error.
We need to revert this patch since we still use those make targets.
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|
|
|
|
|
|
|
|
| |
client headers are exporter in parameter/client; plugin headers in
parameter/plugin.
Also, reduce the list of exported plugin headers to the bare minimum.
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
|
| |
libparameter abd libxmlserializer headers.
Concerning libparameter headers: only core headers (needed for the plugins) are
currently exported. We'll need to export the client headers too, but we must
make a distiction between the two classes of headers. Also, some currently
exported core headers might not be needed (some cleanup is needed).
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
| |
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
| |
It is accessed through dlopen().
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
| |
Run "cmake -DCMAKE_INSTALL_PREFIX=/path/to/install ." for choosing a custom
prefix (optional: if it is not specified, a default directory will be chosen).
Run "make install" for installing all generated files.
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
| |
1) Generate the Makefiles with "cmake";
2) compile all targets with "make".
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
| |
The plugins' Android.mk will directly access libparameter's include dir.
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
| |
That name was too generic and may have conflicted in the future.
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
| |
Pathmaps for libxml2, stlport and icu4c are not defined in vanilla AOSP.
As temporary fix for compilation on vanilla AOSP, we need to hardcode them
again. Commit 55f41bcc3edf282f236539bb26bd6dc8638f235e introduced the use of
include-path-for.
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
| |
Add license header in all source files and Makefiles,
Add a "COPYING" file containing the license text.
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 168727
In the PFW structure file, it is not possible to include a component
library from another XML file.
Implement the possibility to import component from another XML file
that would be included in a structure XML file and that would
describe a component library.
Change-Id: Id6125140de1c8e9882375d01199f695b929f45e2
Signed-off-by: Guillaume Denneulin <guillaume.denneulin@intel.com>
|