| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
Bug 246391
Change-Id: I662b7b0f90c97cb169978e1b64ad1fe32c440cf5
Signed-off-by: Jean-Michel Trivi <jmtrivi@google.com>
|
|
|
|
|
|
|
|
|
| |
It's an error to build .a without source file on Mac.
These two empty static libraries aren't used anywhere.
Bug: 21669400
Change-Id: I73e0899378256ddf802eb7a3aafdbe43559baefe
(cherry picked from commit f1ef7259741bdf99e2a5991bc12aa6cf4f551785)
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will need to be submitted upstream, but for now it's blocking the
build.
Can't test yet as the build is still red, but there's no risk doing
this for now because none of these modules are used yet.
Bug: 20915699
Change-Id: I9e7c8e237bec134985735dee4b4225b29793a792
(cherry picked from commit 6368380f06a48b0049118140f6ac5059f4e7f0f0)
|
|
|
|
| |
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
| |
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
| |
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
| |
Backsynchronizer is dynamically allocated for simulation purpose.
Nevertheless, this is useless as this can be easily achieved thanks to a
typedef.
This patch simplify the backsynchronization use.
Signed-off-by: Sébastien Gonzalve <oznog@users.noreply.github.com>
|
|
|
|
|
|
|
|
|
| |
On windows platform, the definition of a function pointer to a member
of a given class requires visibility on the header of that class,
otherwize memory corruption may occur at deletion time.
Change-Id: Ifa4943ef0f3e02542c6641959cf67384103bfc69
Signed-off-by: Patrick Benavoli <patrick.benavoli@intel.com>
|
|
|
|
|
|
|
|
| |
Remove misleading hungarian notation of variable name in
CRuleParser::iterate() that was making the code hard to read/maintain.
Change-Id: I7a034d7999f419263551c3ed9a7c26cda38e3818
Signed-off-by: Sebastien Gonzalve <sebastien.gonzalve@intel.com>
|
|
|
|
|
|
|
|
| |
This patch removes the type mismatch warnings revealed by Windows 64
compiler. Wherever necessary, used size_t type for size related data.
Change-Id: Ie045ce95940cd83fe8d681168ac9526fc6028d43
Signed-off-by: Patrick Benavoli <patrick.benavoli@intel.com>
|
|
|
|
|
|
|
|
| |
Made _bValidateSchemasOnStart attribute initialized as part of the
constructor's initializer list.
Change-Id: I8f345b5c17f33e012b69005e01dc31a270e41778
Signed-off-by: Patrick Benavoli <patrick.benavoli@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Those functions are used in one place and let the caller transform a
std::string to a char * which makes the use of alloca necessary.
Moreover, the readString cannot know if the pointer given in input
points to a buffer with enough space, making it dangerous.
This patch reworks the API so that write/readString() get std::string
and lets the implementation play with char *. This also allows to get
rid of alloca() use which is quite dangerous.
Change-Id: I973e4987278289bb914c4e194b86e924a1c88a6d
Signed-off-by: Sebastien Gonzalve <sebastien.gonzalve@intel.com>
|
|
|
|
|
|
|
|
|
| |
Spurious execution mode removed from files:
- parameter/Element.cpp
- utility/convert.hpp
Change-Id: I5d47d505e8c3d9f55ad975c34b51d7caa4905ab9
Signed-off-by: Sebastien Gonzalve <sebastien.gonzalve@intel.com>
|
|
|
|
|
|
|
|
| |
CElementBuilder constructor had a ";" right after its defintion.
This patch removes it.
Change-Id: I60551bf9610b1760181d9b206a98f566cef78f0b
Signed-off-by: Sebastien Gonzalve <sebastien.gonzalve@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
When translating a numerical value to literal for an inclusive
criterion type, if the numerical value is not found into the map
of pairs, it appends anyway the "|".
This patch removes this artifacts display if the numerical value is not
part of the acceptable values of this criterion type.
Change-Id: I2ff4ee1ae6e6e3ac87c94c596bae3ae534f173c4
Signed-off-by: Francois Gaffie <francois.gaffie@intel.com>
|
|
|
|
| |
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
It didn't have a license header. Even though we received explicit authorization
to use it, it wasn't a comfortable situation.
This is an original implementation that only keeps the APIs we use in the
parameter-framework and keep them identical (except for a small exception). The
behaviour is also exactly the same.
Change-Id: I85a69c76027ee026a693d79cd19edd3b86796f9d
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
| |
Signed-off-by: Jules Clero <julesx.clero@intel.com>
|
|
|
|
|
|
|
|
|
| |
If the parameter configuration file path does not contain a "/"
it used to assert as it could not find it's folder.
Use "." this case.
Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When calling getNumericalValue on inclusive criterion, the value
to be outputed is never initialized. The Criterion type will append
the value corresponding to each literal value to the uninitialized value
leading to undefined behavior.
This patch initializes the output value.
Issue: GMINL-6007
Change-Id: Id9fc8b010b4d0b6dfc921825387817789d35e5ba
Signed-off-by: Francois Gaffie <francois.gaffie@intel.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Since 3adb785eb097028750fc1b4c5ecab3bebf1a9ae3, CParameterMgr::init should not
be called directly. However, it was kept public and CParameterMgrFullConnector
was using it.
Make it private and remove its use from CParameterMgrFullConnector.
Signed-off-by: Frederic Boisnard <frederic.boisnard@intel.com>
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
| |
The overridden implementation was only calling the base implementation. It can
therefore can be completely removed as it is the default behaviour.
Change-Id: Ic0eadf82abfdaad0ca76d3e9a757544d5ec31427
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|\
| |
| | |
Fix pointer arithmetic instead of concat
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
`"my number " + 5` does not produces `"my number 5"` but rather `"mber "`.
If the number was greater than `len(string) + 2`
(pointing to the \0 and one past the end in authorized, more in UB)
the result would have been undefined behaviour.
Transforme the number to std::string using toString.
Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
|
|\ \
| |/
|/| |
Iminleg rebase
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When refactoring Element::toXml, we forgot to make the necessary adaptation in
SystemClass::toXml. The latter does not need to set the Name attribute anymore
because this is taken care of by the base toXml method.
SystemClass::toXml now only calls the base and can therefore be completely
removed.
Change-Id: Ibd12feaac2c101dcc22e8716e332cb02f03ba99a
Tracked-On: https://jira01.devtools.intel.com/browse/IMINAN-19676
Signed-off-by: David Wagner <david.wagner@intel.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
libremote-processor headers are needed by the parameter core.
This patch adds explicitily the dependency to this module.
Change-Id: I7a223a0abd35f9524a047ca92e1029c5cef38e38
Tracked-On: https://jira01.devtools.intel.com/browse/IMINAN-19676
Signed-off-by: Philippe Afonso <philippex.afonso@intel.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Some parameters need to be converted to
logarithm.
This can be the case for volumes that come
from HAL as mere decimal values.
This patch adds the LogarithmAdaptationParameter
type.
Change-Id: Ic64232816a82c56a6ddffa5fdccda356eb4ec9c7
Tracked-On: https://jira01.devtools.intel.com/browse/IMINAN-16954
Signed-off-by: Piotr Diop <piotrx.diop@intel.com>
Reviewed-on: https://android.intel.com:443/320371
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
BZ: 209937
This patch solves 1 issue regarding XML export feature:
- ParameterMgr.cpp::exportElementToXMLString(): This method was receiving a
useless bValidateWithSchema argument. Indeed, elements in memory are
necessarily valid (unlike documents coming from external sources).
Change-Id: I55bf84c8ff53c37c9fc55e60f7f64e8776a43dc7
Signed-off-by: Patrick Benavoli <patrick.benavoli@intel.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
BZ: 209937
The "listCriteria" command returns the list of criteria in a human readable
way. However, external tools that require to know this list of criteria have
trouble parsing this output. An XML output would solve the issue.
Changed "listCriteria" command to accept "XML" as first and only argument.
In the end, listCriteria command accepts the 3 following forms:
- listCriteria => will list the criteria states and type content in a human
readable format
- listCriteria csv|CSV => will list the criteria states and type content in a
CSV format
- listCriteria xml|XML => will list the criteria states and type content in an
XML format
Removed python binding accordingly.
Change-Id: Ib060ec0a5d1ff87ba6c25caf4e0d5839a7927715
Signed-off-by: Patrick Benavoli <patrick.benavoli@intel.com>
Signed-off-by: Sebastien Gonzalve <sebastien.gonzalve@intel.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
BZ: 208504
Before this patch there was a crash in CElement destructor in Ubuntu upon
destuction of parameter framework instance.
The crash was caused by the attempt to call unmapped code: The subsystem
plugin libraries were getting unloaded before the execution of the subsystem
destructors.
Note:
In Android the issue is not seen since library unload is not implemented.
This patch ensures SystemClass destructor destroys the subsystems explicitely
unloading the plugins.
Change-Id: I19dad262b384bdbd63c7c319a41a5d547d0e75e9
Signed-off-by: Patrick Benavoli <patrick.benavoli@intel.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
BZ: 208504
Concerns the handle to remote processor library.
In PFW coding style, the variables are named like in english language:
The actual nature of the object needs to lie at the end of the name.
Change-Id: If41218c3456d07c81a953182488c6ae71e31b6d8
Signed-off-by: Patrick Benavoli <patrick.benavoli@intel.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
BZ: 208504
Some source files were mistakenly assigned the executable flag.
Change-Id: Iad85123c331d2599126ed46f070fe10614f7c360
Signed-off-by: Patrick Benavoli <patrick.benavoli@intel.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
BZ: 208504
CParameterAccessContext::outRawFormatIsHex() was missing the const modifier.
Change-Id: I3120a231d2dff8f4274b95cd2d3c8ff0817bf8ac
Signed-off-by: Patrick Benavoli <patrick.benavoli@intel.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
BZ: 207091
The parameter platform manager used to initialize the element tree.
However, this is too early for plugins, since they need information from
the core which have not been initialized yet.
This patch delays the initialization of the element tree by adding it to
the load() function of the ParameterMgr.
Change-Id: I98e0e3a20ac0af2736eddc4c8349911eb1d1a691
Signed-off-by: Guillaume Denneulin <guillaume.denneulin@intel.com>
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
Reviewed-on: https://android.intel.com/215426
Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com>
Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com>
Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com>
Tested-by: Rocard, KevinX <kevinx.rocard@intel.com>
|
|\ \
| |/
|/|
| |
| | |
krocard/Fix_error_message_in_case_of_unknown_criterion_value
Fix error message in case of unknown criterion value
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When failing to parse a criterion rule, the pfw was outputing:
Value error:
This did not help to find the root cause.
With this patch it would have output:
Value error: <Input value> is not part of criterion <Criterion>
Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In some setup, users might not want to start the remote interface even if the
toplevel configuration file allows it.
The parameter-framework client can now override the remote interface starting
policy. This was, until now, only dictated by the 'TuningAllowed' attribute in
the toplevel configuration file and the presence of the libremote-processor
library.
This method is forwarded to the connectors and the bindings.
Change-Id: Ib6dc272dfc7114125fdafd1a58642cde88847752
Signed-off-by: David Wagner <david.wagner@intel.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It will allow users to tell the parameter-framework where the Schemas are
instead of letting it guess.
These methods are also added to both "Platform" and "Full" connectors.
Change-Id: I7fe3b2fd2c6dba1d90d36de97e6db7d71b2c686f
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|\ \
| | |
| | | |
New "ParameterMgr" Connector, as alternative to the ParameterMgrPlatformConnector. This "Full" connector offers all the capabilities of the ParameterMgr.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is a new connector that implements (almost) all of the parameter-framework
capabilities, in contrast to CParameterMgrPlatformConnector which only
implements criteria creation, modification, and application and dynamic
parameter handling capabilities.
It will allow user to programatically do whatever the PFW can do, e.g. create
domains and configurations.
Change-Id: Ide118aaaae4f84fa7280d2cae470de0c024c0f00
Signed-off-by: David Wagner <david.wagner@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
There were duplicates in the CMakeLists.txt; this patch removes them and sorts
the filenames so that they are identical in Android.mk and CMakeLists.txt.
Please keep the names sorted, using the shell's "sort -u" command.
Change-Id: I027676beb4ee19de2341cd65e0e5c077cddb5627
Signed-off-by: David Wagner <david.wagner@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This will make it possible to have different kind of ParameterMgr connectors
instead of hardcoding ParameterMgrPlatformConnector in ParameterMgrLogger.
Change-Id: Ia78d9f56c8cc73321e1956856755a56a3569b517
Signed-off-by: David Wagner <david.wagner@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
There is no need for these method to be public as they are only used
internaly.
Change-Id: I172257211f35de26c11aaef499f7c847d55ced0b
Signed-off-by: David Wagner <david.wagner@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This applies only to setParameter: this commands should only be available in
Tuning Mode. This is enforced by moving the tuning mode check from the remote
interface to the internal CParameterMgr::accessParameterValue() method.
Additionaly, CParameterMgr::accessValue is made private.
Change-Id: I189362a768ce1cd9709b6e5d48cd833f7ca56479
Signed-off-by: David Wagner <david.wagner@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
logStructureContent() wasn't called by anybody.
Change-Id: I152b6f1790a545ab302ca90389c78c43a0bb6056
Signed-off-by: David Wagner <david.wagner@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Some public methods returned a "CCommandHandler" enum value type, which is
intended to be used in the remote tuning methods only. Primitive bools must be
used instead.
Change-Id: Iac7a565f701c65875b3f1dd0896bf31d7d843d72
Signed-off-by: David Wagner <david.wagner@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
These methods are:
- renameDomain
- setSequenceAwareness
- getSequenceAwareness
- renameConfiguration
- setElementSequence
- setApplicationRule
- getApplicationRule
- clearApplicationRule
The "remote tuning" methods are also modified to use them instead of directly
accessing inner objects and the tuning mode checking is moved to the public C++
method when applicable.
Change-Id: I9cdd0abbacb76232cd746878dca9ab619e8b6b58
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|\ \ \
| |/ /
| | | |
Single domain import/export remote commands
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The command is used as follows:
importDomainWithSettingsXML <file path> [overwrite]
It reads the file given as first argument (path must be absolute) and imports
the domain found in it.
It does not check whether it overlaps with another domain (same elements in two
domains). It does, however, check if there is an existing domain with the same
name as the one being imported. If so and if the (optional) second argument
is "overwrite", it will first delete the existing domain; if not it will refuse
to import the new domain.
Change-Id: I7aaa225f2f1a296f52dc8a97f55e1ff70c06d567
Signed-off-by: David Wagner <david.wagner@intel.com>
|