From ccb745447386f49e018fe39d1ec54a652eefa57f Mon Sep 17 00:00:00 2001
From: David Wagner <david.wagner@intel.com>
Date: Wed, 24 Sep 2014 09:42:11 +0200
Subject: Fix a use-after-free issue

In CBinaryStream, a member gets used after it has been destroyed. This was
caught by a static code analyser.

Issue: GMINL-1702
Change-Id: I5c93855f12a8f392e1f4249a15048816fb0f13ce
Signed-off-by: David Wagner <david.wagner@intel.com>
Reviewed-on: https://android.intel.com/278483
Reviewed-by: cactus <cactus@intel.com>
Tested-by: cactus <cactus@intel.com>
Reviewed-by: Beatty, Robert M <robert.m.beatty@intel.com>
Tested-by: Beatty, Robert M <robert.m.beatty@intel.com>
---
 parameter/BinaryStream.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'parameter')

diff --git a/parameter/BinaryStream.cpp b/parameter/BinaryStream.cpp
index 42b6185..701e9b8 100644
--- a/parameter/BinaryStream.cpp
+++ b/parameter/BinaryStream.cpp
@@ -46,12 +46,12 @@ CBinaryStream::CBinaryStream(const string& strFileName, bool bOut, uint32_t uiDa
 
 CBinaryStream::~CBinaryStream()
 {
-    delete [] _puiData;
-
     if (_bOpen) {
 
         close();
     }
+
+    delete [] _puiData;
 }
 
 bool CBinaryStream::open(string& strError)
-- 
cgit v1.1