From cf428e5ee22d8bb8a182d81f0433aeccf89fa810 Mon Sep 17 00:00:00 2001 From: David Wagner Date: Fri, 2 Jan 2015 14:26:27 +0100 Subject: test-platform: fix boolean remote getter commands output Getter commands return a boolean value ("true" or "false") were implemented by a generic method. However, this method returned a "Done" result, which suppresses the normal output and prints "Done" instead. This is fixed by making this method return a "Success" result, which is interpreted as "give the output to the user". In the same time, we remove a useless "cast to void" which is usually a workaround for unused variables. Change-Id: I49115d3b29967fd455ffc0b703dfb4f4d438280e Signed-off-by: David Wagner --- test/test-platform/TestPlatform.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'test') diff --git a/test/test-platform/TestPlatform.cpp b/test/test-platform/TestPlatform.cpp index f1e99b6..b2b895c 100644 --- a/test/test-platform/TestPlatform.cpp +++ b/test/test-platform/TestPlatform.cpp @@ -245,11 +245,10 @@ CTestPlatform::CommandReturn CTestPlatform::getter( const IRemoteCommand& remoteCommand, string& strResult) { (void)remoteCommand; - (void)strResult; strResult = (_pParameterMgrPlatformConnector->*getFunction)() ? "true" : "false"; - return CTestPlatform::CCommandHandler::EDone; + return CTestPlatform::CCommandHandler::ESucceeded; } CTestPlatform::CommandReturn CTestPlatform::setCriterionState( -- cgit v1.1