From d770f7a4082873887833d886fb8aeacf1eeb57af Mon Sep 17 00:00:00 2001 From: Jules Clero Date: Wed, 11 Feb 2015 09:38:07 +0100 Subject: Fix tSTRING_128 parenthesis error This test was trying to set string parameter containing parenthesis through remote-process without escaped them. This patch introduces the escaped value in order to correctly use the remote-process command through bash. Signed-off-by: Jules Clero --- test/functional-tests/PfwTestCase/Types/tSTRING_128.py | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) (limited to 'test') diff --git a/test/functional-tests/PfwTestCase/Types/tSTRING_128.py b/test/functional-tests/PfwTestCase/Types/tSTRING_128.py index 6ef1876..0ed6e85 100644 --- a/test/functional-tests/PfwTestCase/Types/tSTRING_128.py +++ b/test/functional-tests/PfwTestCase/Types/tSTRING_128.py @@ -229,8 +229,12 @@ class TestCases(PfwTestCase): log.I("STR_CHAR128 parameter Parenthese Char = %s" % (value)) param_check = commands.getoutput('cat $PFW_FILESYSTEM/STR_CHAR128') #Set parameter value - out, err = self.pfw.sendCmd("setParameter", self.param_name, value) + out, err = self.pfw.sendCmd("setParameter", self.param_name, "'%s'" % (value)) assert err == None, log.E("When setting parameter %s : %s" % (self.param_name, err)) + assert out == "Done", log.F("Expected : Done, found : %s" % (out)) + #Get parameter value + out, err = self.pfw.sendCmd("getParameter", self.param_name) + assert err == None, log.E("When getting parameter %s : %s" % (self.param_name, err)) assert out == value, log.F("BLACKBOARD : Incorrect value for %s, expected: %s, found: %s" % (self.param_name, value, out)) #Check parameter value on filesystem assert commands.getoutput('cat $PFW_FILESYSTEM/STR_CHAR128') == value, log.F("FILESYSTEM : parameter update error") @@ -254,8 +258,12 @@ class TestCases(PfwTestCase): log.I("STR_CHAR128 parameter Parenthese Char = %s" % (value)) param_check = commands.getoutput('cat $PFW_FILESYSTEM/STR_CHAR128') #Set parameter value - out, err = self.pfw.sendCmd("setParameter", self.param_name, value) + out, err = self.pfw.sendCmd("setParameter", self.param_name, "'%s'" % value) assert err == None, log.E("When setting parameter %s : %s" % (self.param_name, err)) + assert out == "Done", log.F("Expected : Done, found : %s" % (out)) + #Get parameter value + out, err = self.pfw.sendCmd("getParameter", self.param_name) + assert err == None, log.E("When getting parameter %s : %s" % (self.param_name, err)) assert out == value, log.F("BLACKBOARD : Incorrect value for %s, expected: %s, found: %s" % (self.param_name, value, out)) #Check parameter value on filesystem assert commands.getoutput('cat $PFW_FILESYSTEM/STR_CHAR128') == value, log.F("FILESYSTEM : parameter update error") -- cgit v1.1