aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarco Nelissen <marcone@google.com>2015-05-14 10:22:40 -0700
committerWolfgang Wiedmeyer <wolfgit@wiedmeyer.de>2015-10-19 02:06:12 +0200
commitb0ef1bc41dcd5690c2df1e2e9df15c695daa39e3 (patch)
tree67b76a41f7d42912f05ba3a89d910fef0c4d64a9
parent2adc45f2616bd8b2f81e333f76ade66b62d38fd8 (diff)
downloadexternal_tremolo-master.zip
external_tremolo-master.tar.gz
external_tremolo-master.tar.bz2
Add sanity checks to fix crashHEADmaster
Copy Huffman tree sanity check from libvorbis to avoid out of bounds memory access later on. Bug: 21048776 Change-Id: I3c508572501af188af4224e2a295e9f2554ec9c0 (cherry picked from commit 52193fa3472b79873e73044ce02e1c0a67c85043) Tested-by: Wolfgang Wiedmeyer <wolfgit@wiedmeyer.de>
-rw-r--r--Tremolo/codebook.c14
1 files changed, 14 insertions, 0 deletions
diff --git a/Tremolo/codebook.c b/Tremolo/codebook.c
index 0b596ee..0d34f56 100644
--- a/Tremolo/codebook.c
+++ b/Tremolo/codebook.c
@@ -210,6 +210,20 @@ static int _make_words(char *l,long n,ogg_uint32_t *r,long quantvals,
}
}
+ // following sanity check copied from libvorbis
+ /* sanity check the huffman tree; an underpopulated tree must be
+ rejected. The only exception is the one-node pseudo-nil tree,
+ which appears to be underpopulated because the tree doesn't
+ really exist; there's only one possible 'codeword' or zero bits,
+ but the above tree-gen code doesn't mark that. */
+ if(b->used_entries != 1){
+ for(i=1;i<33;i++)
+ if(marker[i] & (0xffffffffUL>>(32-i))){
+ return 1;
+ }
+ }
+
+
return 0;
}