From ca8e039fec1352e2ece4fdbd6fde92fd461565a3 Mon Sep 17 00:00:00 2001 From: Jouni Malinen Date: Sun, 1 Apr 2012 17:55:20 +0300 Subject: Fix memory leaks on radius_client_send error paths In case this function returns an error, the RADIUS message needs to freed in the caller. Signed-hostap: Jouni Malinen --- src/ap/accounting.c | 15 +++++++++------ src/ap/ieee802_11_auth.c | 3 ++- 2 files changed, 11 insertions(+), 7 deletions(-) (limited to 'src') diff --git a/src/ap/accounting.c b/src/ap/accounting.c index 2a04560..edda88b 100644 --- a/src/ap/accounting.c +++ b/src/ap/accounting.c @@ -259,8 +259,9 @@ void accounting_sta_start(struct hostapd_data *hapd, struct sta_info *sta) hapd, sta); msg = accounting_msg(hapd, sta, RADIUS_ACCT_STATUS_TYPE_START); - if (msg) - radius_client_send(hapd->radius, msg, RADIUS_ACCT, sta->addr); + if (msg && + radius_client_send(hapd->radius, msg, RADIUS_ACCT, sta->addr) < 0) + radius_msg_free(msg); sta->acct_session_started = 1; } @@ -358,9 +359,10 @@ static void accounting_sta_report(struct hostapd_data *hapd, goto fail; } - radius_client_send(hapd->radius, msg, - stop ? RADIUS_ACCT : RADIUS_ACCT_INTERIM, - sta->addr); + if (radius_client_send(hapd->radius, msg, + stop ? RADIUS_ACCT : RADIUS_ACCT_INTERIM, + sta->addr) < 0) + goto fail; return; fail: @@ -463,7 +465,8 @@ static void accounting_report_state(struct hostapd_data *hapd, int on) return; } - radius_client_send(hapd->radius, msg, RADIUS_ACCT, NULL); + if (radius_client_send(hapd->radius, msg, RADIUS_ACCT, NULL) < 0) + radius_msg_free(msg); } diff --git a/src/ap/ieee802_11_auth.c b/src/ap/ieee802_11_auth.c index 109c4bc..27b0789 100644 --- a/src/ap/ieee802_11_auth.c +++ b/src/ap/ieee802_11_auth.c @@ -193,7 +193,8 @@ static int hostapd_radius_acl_query(struct hostapd_data *hapd, const u8 *addr, goto fail; } - radius_client_send(hapd->radius, msg, RADIUS_AUTH, addr); + if (radius_client_send(hapd->radius, msg, RADIUS_AUTH, addr) < 0) + goto fail; return 0; fail: -- cgit v1.1