From 5a48712501982c7276c1455e280e0b95149bdd0b Mon Sep 17 00:00:00 2001 From: Mathias Agopian Date: Tue, 16 Feb 2010 19:42:32 -0800 Subject: fix [2447659] fix improper usage of the YCbCr_420_SP format --- camera/libcameraservice/CameraService.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'camera/libcameraservice') diff --git a/camera/libcameraservice/CameraService.cpp b/camera/libcameraservice/CameraService.cpp index f66a2d3..7e81e90 100644 --- a/camera/libcameraservice/CameraService.cpp +++ b/camera/libcameraservice/CameraService.cpp @@ -607,8 +607,9 @@ status_t CameraService::Client::registerPreviewBuffers() CameraParameters params(mHardware->getParameters()); params.getPreviewSize(&w, &h); + // don't use a hardcoded format here ISurface::BufferHeap buffers(w, h, w, h, - HAL_PIXEL_FORMAT_YCbCr_420_SP, + HAL_PIXEL_FORMAT_YCrCb_420_SP, mOrientation, 0, mHardware->getPreviewHeap()); @@ -928,8 +929,9 @@ void CameraService::Client::handleShutter( h &= ~1; LOGV("Snapshot image width=%d, height=%d", w, h); } + // FIXME: don't use hardcoded format constants here ISurface::BufferHeap buffers(w, h, w, h, - HAL_PIXEL_FORMAT_YCbCr_420_SP, mOrientation, 0, + HAL_PIXEL_FORMAT_YCrCb_420_SP, mOrientation, 0, mHardware->getRawHeap()); mSurface->registerBuffers(buffers); -- cgit v1.1