diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2009-01-12 23:25:05 +0100 |
|---|---|---|
| committer | Liam Girdwood <lrg@slimlogic.co.uk> | 2009-01-17 13:46:40 +0000 |
| commit | 5dbdf7354821e00e4419ac3520d05d126857d56e (patch) | |
| tree | dfa1137175cb67fba9b26974b4db520f166b3787 | |
| parent | 1de9e8e70f5acc441550ca75433563d91b269bbe (diff) | |
| download | kernel_samsung_smdk4412-5dbdf7354821e00e4419ac3520d05d126857d56e.zip kernel_samsung_smdk4412-5dbdf7354821e00e4419ac3520d05d126857d56e.tar.gz kernel_samsung_smdk4412-5dbdf7354821e00e4419ac3520d05d126857d56e.tar.bz2 | |
move wm8400-regulator's probe function to .devinit.text
A pointer to wm8400_regulator_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded. Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.
An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
| -rw-r--r-- | drivers/regulator/wm8400-regulator.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/regulator/wm8400-regulator.c b/drivers/regulator/wm8400-regulator.c index 48b372e..56e23d4 100644 --- a/drivers/regulator/wm8400-regulator.c +++ b/drivers/regulator/wm8400-regulator.c @@ -289,7 +289,7 @@ static struct regulator_desc regulators[] = { }, }; -static int __init wm8400_regulator_probe(struct platform_device *pdev) +static int __devinit wm8400_regulator_probe(struct platform_device *pdev) { struct regulator_dev *rdev; |