|author||Andy Lutomirski <firstname.lastname@example.org>||2015-09-20 16:32:04 -0700|
|committer||Ben Hutchings <email@example.com>||2015-10-13 03:46:11 +0100|
x86/paravirt: Replace the paravirt nop with a bona fide empty function
commit fc57a7c68020dcf954428869eafd934c0ab1536f upstream. PARAVIRT_ADJUST_EXCEPTION_FRAME generates this code (using nmi as an example, trimmed for readability): ff 15 00 00 00 00 callq *0x0(%rip) # 2796 <nmi+0x6> 2792: R_X86_64_PC32 pv_irq_ops+0x2c That's a call through a function pointer to regular C function that does nothing on native boots, but that function isn't protected against kprobes, isn't marked notrace, and is certainly not guaranteed to preserve any registers if the compiler is feeling perverse. This is bad news for a CLBR_NONE operation. Of course, if everything works correctly, once paravirt ops are patched, it gets nopped out, but what if we hit this code before paravirt ops are patched in? This can potentially cause breakage that is very difficult to debug. A more subtle failure is possible here, too: if _paravirt_nop uses the stack at all (even just to push RBP), it will overwrite the "NMI executing" variable if it's called in the NMI prologue. The Xen case, perhaps surprisingly, is fine, because it's already written in asm. Fix all of the cases that default to paravirt_nop (including adjust_exception_frame) with a big hammer: replace paravirt_nop with an asm function that is just a ret instruction. The Xen case may have other problems, so document them. This is part of a fix for some random crashes that Sasha saw. Reported-and-tested-by: Sasha Levin <firstname.lastname@example.org> Signed-off-by: Andy Lutomirski <email@example.com> Link: http://firstname.lastname@example.org Signed-off-by: Thomas Gleixner <email@example.com> [bwh: Backported to 3.2: adjust filename, context] Signed-off-by: Ben Hutchings <firstname.lastname@example.org>
2 files changed, 23 insertions, 4 deletions
diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
index 8d15c69..f6daf3c 100644
@@ -1504,7 +1504,18 @@ END(error_exit)
/* runs on exception stack */
+ * Fix up the exception frame if we're on Xen.
+ * PARAVIRT_ADJUST_EXCEPTION_FRAME is guaranteed to push at most
+ * one value to the stack on native, so it may clobber the rdx
+ * scratch slot, but it won't clobber any of the important
+ * slots past it.
+ * Xen is a different story, because the Xen frame itself overlaps
+ * the "NMI executing" variable.
subq $ORIG_RAX-R15, %rsp
diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c
index 84c938f..af5b675 100644
@@ -38,10 +38,18 @@
-/* nop stub */
+ * nop stub, which must not clobber anything *including the stack* to
+ * avoid confusing the entry prologues.
+extern void _paravirt_nop(void);
+asm (".pushsection .entry.text, \"ax\"\n"
+ ".global _paravirt_nop\n"
+ ".size _paravirt_nop, . - _paravirt_nop\n\t"
+ ".type _paravirt_nop, @function\n\t"
/* identity function, which can be inlined */
u32 _paravirt_ident_32(u32 x)