diff options
| author | Sudip Mukherjee <sudipm.mukherjee@gmail.com> | 2015-07-20 17:27:21 +0530 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2015-10-13 03:46:05 +0100 |
| commit | b3170aab0b1a13c7c63061cee5dc3a5d49a65225 (patch) | |
| tree | 68d3d4788aaed53183c5d16f28bccda78d80f21b | |
| parent | 41e3025eacd6daafc40c3e7850fbcabc8b847805 (diff) | |
| download | kernel_samsung_smdk4412-b3170aab0b1a13c7c63061cee5dc3a5d49a65225.zip kernel_samsung_smdk4412-b3170aab0b1a13c7c63061cee5dc3a5d49a65225.tar.gz kernel_samsung_smdk4412-b3170aab0b1a13c7c63061cee5dc3a5d49a65225.tar.bz2 | |
auxdisplay: ks0108: fix refcount
commit bab383de3b84e584b0f09227151020b2a43dc34c upstream.
parport_find_base() will implicitly do parport_get_port() which
increases the refcount. Then parport_register_device() will again
increment the refcount. But while unloading the module we are only
doing parport_unregister_device() decrementing the refcount only once.
We add an parport_put_port() to neutralize the effect of
parport_get_port().
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | drivers/auxdisplay/ks0108.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/auxdisplay/ks0108.c b/drivers/auxdisplay/ks0108.c index 5b93852..0d75285 100644 --- a/drivers/auxdisplay/ks0108.c +++ b/drivers/auxdisplay/ks0108.c @@ -139,6 +139,7 @@ static int __init ks0108_init(void) ks0108_pardevice = parport_register_device(ks0108_parport, KS0108_NAME, NULL, NULL, NULL, PARPORT_DEV_EXCL, NULL); + parport_put_port(ks0108_parport); if (ks0108_pardevice == NULL) { printk(KERN_ERR KS0108_NAME ": ERROR: " "parport didn't register new device\n"); |