aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoe Stringer <joestringer@nicira.com>2015-07-21 21:37:31 -0700
committerBen Hutchings <ben@decadent.org.uk>2015-08-12 16:33:22 +0200
commitc2e3fd156ee129b802376e2fd0ac0aba2f909e08 (patch)
treec54cc8e0fb1a31b90701090384ccb8cfd98df9eb
parent0f0aa7b1634eeed34810f098a8efd80f33486ca4 (diff)
downloadkernel_samsung_smdk4412-c2e3fd156ee129b802376e2fd0ac0aba2f909e08.zip
kernel_samsung_smdk4412-c2e3fd156ee129b802376e2fd0ac0aba2f909e08.tar.gz
kernel_samsung_smdk4412-c2e3fd156ee129b802376e2fd0ac0aba2f909e08.tar.bz2
netfilter: nf_conntrack: Support expectations in different zones
commit 4b31814d20cbe5cd4ccf18089751e77a04afe4f2 upstream. When zones were originally introduced, the expectation functions were all extended to perform lookup using the zone. However, insertion was not modified to check the zone. This means that two expectations which are intended to apply for different connections that have the same tuple but exist in different zones cannot both be tracked. Fixes: 5d0aa2ccd4 (netfilter: nf_conntrack: add support for "conntrack zones") Signed-off-by: Joe Stringer <joestringer@nicira.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
-rw-r--r--net/netfilter/nf_conntrack_expect.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/net/netfilter/nf_conntrack_expect.c b/net/netfilter/nf_conntrack_expect.c
index 7918eb7..cec0ed5 100644
--- a/net/netfilter/nf_conntrack_expect.c
+++ b/net/netfilter/nf_conntrack_expect.c
@@ -205,7 +205,8 @@ static inline int expect_clash(const struct nf_conntrack_expect *a,
a->mask.src.u3.all[count] & b->mask.src.u3.all[count];
}
- return nf_ct_tuple_mask_cmp(&a->tuple, &b->tuple, &intersect_mask);
+ return nf_ct_tuple_mask_cmp(&a->tuple, &b->tuple, &intersect_mask) &&
+ nf_ct_zone(a->master) == nf_ct_zone(b->master);
}
static inline int expect_matches(const struct nf_conntrack_expect *a,