aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSimon Farnsworth <simon@farnz.org.uk>2009-01-19 21:19:29 +0000
committerDavid Woodhouse <David.Woodhouse@intel.com>2009-01-27 14:18:17 +1100
commit4306cad6fe02e2946183ab29e510f94190b8fff3 (patch)
tree65e5640bd61dff8c9440f548f7c41a29875052c4
parentb76811af7606b36cb0703f04449c301b9634dcbc (diff)
downloadkernel_samsung_smdk4412-4306cad6fe02e2946183ab29e510f94190b8fff3.zip
kernel_samsung_smdk4412-4306cad6fe02e2946183ab29e510f94190b8fff3.tar.gz
kernel_samsung_smdk4412-4306cad6fe02e2946183ab29e510f94190b8fff3.tar.bz2
solos: Slight debugging improvements
Print a message if pskb_expand_head fails. Make atmdebug writable by root, so that you can turn printing of data sent to and received from the card on and off at runtime - useful for tracking corruption. Signed-off-by: Simon Farnsworth <simon@farnz.org.uk> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
-rw-r--r--drivers/atm/solos-pci.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index f030954..3daa3a3 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -91,7 +91,7 @@ MODULE_LICENSE("GPL");
MODULE_PARM_DESC(debug, "Enable Loopback");
MODULE_PARM_DESC(atmdebug, "Print ATM data");
module_param(debug, int, 0444);
-module_param(atmdebug, int, 0444);
+module_param(atmdebug, int, 0644);
static int opens;
@@ -541,6 +541,7 @@ static int psend(struct atm_vcc *vcc, struct sk_buff *skb)
ret = pskb_expand_head(skb, expand_by, 0, GFP_ATOMIC);
if (ret) {
+ dev_warn(&card->dev->dev, "pskb_expand_head failed.\n");
solos_pop(vcc, skb);
return ret;
}