diff options
| author | Julia Lawall <julia@diku.dk> | 2010-05-15 23:17:19 +0200 |
|---|---|---|
| committer | John W. Linville <linville@tuxdriver.com> | 2010-06-02 16:13:11 -0400 |
| commit | a465a2cc6eb55908a70e386b729293e9d9e4726e (patch) | |
| tree | 224364b5cc4277f8d7726f77ea42da0ad80cdfb8 | |
| parent | ff020726a7e963c3b9fb71825b3c33885022a8f0 (diff) | |
| download | kernel_samsung_smdk4412-a465a2cc6eb55908a70e386b729293e9d9e4726e.zip kernel_samsung_smdk4412-a465a2cc6eb55908a70e386b729293e9d9e4726e.tar.gz kernel_samsung_smdk4412-a465a2cc6eb55908a70e386b729293e9d9e4726e.tar.bz2 | |
drivers/net/wireless/ath/ath9k: Use kmemdup
Use kmemdup when some other buffer is immediately copied into the
allocated region.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression from,to,size,flag;
statement S;
@@
- to = \(kmalloc\|kzalloc\)(size,flag);
+ to = kmemdup(from,size,flag);
if (to==NULL || ...) S
- memcpy(to, from, size);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
| -rw-r--r-- | drivers/net/wireless/ath/ath9k/hif_usb.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c index 77b3591..3bd6622 100644 --- a/drivers/net/wireless/ath/ath9k/hif_usb.c +++ b/drivers/net/wireless/ath/ath9k/hif_usb.c @@ -907,12 +907,10 @@ static void ath9k_hif_usb_reboot(struct usb_device *udev) void *buf; int ret; - buf = kmalloc(4, GFP_KERNEL); + buf = kmemdup(&reboot_cmd, 4, GFP_KERNEL); if (!buf) return; - memcpy(buf, &reboot_cmd, 4); - ret = usb_bulk_msg(udev, usb_sndbulkpipe(udev, USB_REG_OUT_PIPE), buf, 4, NULL, HZ); if (ret) |