aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChuck Lever <chuck.lever@oracle.com>2007-09-11 18:00:52 -0400
committerTrond Myklebust <Trond.Myklebust@netapp.com>2007-10-09 17:16:58 -0400
commitb79dc8ced1412e7056f3969bef40a30cc75ee530 (patch)
tree2a21fd59b9c4a38e7d3effad185db40ae60ceb3b
parent906462af4c707ba0238f3579fdb2b594c4ea29c3 (diff)
downloadkernel_samsung_smdk4412-b79dc8ced1412e7056f3969bef40a30cc75ee530.zip
kernel_samsung_smdk4412-b79dc8ced1412e7056f3969bef40a30cc75ee530.tar.gz
kernel_samsung_smdk4412-b79dc8ced1412e7056f3969bef40a30cc75ee530.tar.bz2
SUNRPC: RPC bind failures should be permanent for NULL requests
The purpose of an RPC ping (a NULL request) is to determine whether the remote end is operating and supports the RPC program and version of the request. If we do an RPC bind and the remote's rpcbind service says "this program or service isn't supported" then we have our answer already, and we should give up immediately. This is good for the kernel mount client, as it will cause the request to fail, and then allow an immediate retry with different options. Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
-rw-r--r--net/sunrpc/clnt.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index 04f6e15..b19bacf 100644
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -959,6 +959,11 @@ call_bind_status(struct rpc_task *task)
case -EACCES:
dprintk("RPC: %5u remote rpcbind: RPC program/version "
"unavailable\n", task->tk_pid);
+ /* fail immediately if this is an RPC ping */
+ if (task->tk_msg.rpc_proc->p_proc == 0) {
+ status = -EOPNOTSUPP;
+ break;
+ }
rpc_delay(task, 3*HZ);
goto retry_timeout;
case -ETIMEDOUT: