aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2012-01-11 18:52:10 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-02-03 09:18:52 -0800
commit2fbe11fed22ed2751aaf4b4926f27730aaac5470 (patch)
tree23a80ce32f738643168226950d5cb7a02212513a
parent90af660bec3b2d47e17cb3caae742810656e2d4f (diff)
downloadkernel_samsung_smdk4412-2fbe11fed22ed2751aaf4b4926f27730aaac5470.zip
kernel_samsung_smdk4412-2fbe11fed22ed2751aaf4b4926f27730aaac5470.tar.gz
kernel_samsung_smdk4412-2fbe11fed22ed2751aaf4b4926f27730aaac5470.tar.bz2
xfs: Fix missing xfs_iunlock() on error recovery path in xfs_readlink()
commit 9b025eb3a89e041bab6698e3858706be2385d692 upstream. Commit b52a360b forgot to call xfs_iunlock() when it detected corrupted symplink and bailed out. Fix it by jumping to 'out' instead of doing return. CC: Carlos Maiolino <cmaiolino@redhat.com> Signed-off-by: Jan Kara <jack@suse.cz> Reviewed-by: Alex Elder <elder@kernel.org> Reviewed-by: Dave Chinner <dchinner@redhat.com> Signed-off-by: Ben Myers <bpm@sgi.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--fs/xfs/xfs_vnodeops.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/xfs/xfs_vnodeops.c b/fs/xfs/xfs_vnodeops.c
index 6cc4d41..59509ae 100644
--- a/fs/xfs/xfs_vnodeops.c
+++ b/fs/xfs/xfs_vnodeops.c
@@ -554,7 +554,8 @@ xfs_readlink(
__func__, (unsigned long long) ip->i_ino,
(long long) pathlen);
ASSERT(0);
- return XFS_ERROR(EFSCORRUPTED);
+ error = XFS_ERROR(EFSCORRUPTED);
+ goto out;
}