aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2015-05-01 22:02:47 -0400
committerrogersb11 <brettrogers11@gmail.com>2015-12-18 03:52:19 -0500
commit4de865b6d1dfa81b2a5d01c3cab0770a9aceac0c (patch)
treea81e5cc071ff3049887a21a5193a454f0b8b27de
parent764df269b7e4e2784ab4acb841e503b364552641 (diff)
downloadkernel_samsung_smdk4412-4de865b6d1dfa81b2a5d01c3cab0770a9aceac0c.zip
kernel_samsung_smdk4412-4de865b6d1dfa81b2a5d01c3cab0770a9aceac0c.tar.gz
kernel_samsung_smdk4412-4de865b6d1dfa81b2a5d01c3cab0770a9aceac0c.tar.bz2
ipv4: Missing sk_nulls_node_init() in ping_unhash().
If we don't do that, then the poison value is left in the ->pprev backlink. This can cause crashes if we do a disconnect, followed by a connect(). Change-Id: Ie030e91e18bdd2ac08f993b4f72c130391d96cb3 Tested-by: Linus Torvalds <torvalds@linux-foundation.org> Reported-by: Wen Xu <hotdog3645@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/ipv4/ping.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c
index 06ca6fe..140d420 100644
--- a/net/ipv4/ping.c
+++ b/net/ipv4/ping.c
@@ -153,6 +153,7 @@ void ping_unhash(struct sock *sk)
if (sk_hashed(sk)) {
write_lock_bh(&ping_table.lock);
hlist_nulls_del(&sk->sk_nulls_node);
+ sk_nulls_node_init(&sk->sk_nulls_node);
sock_put(sk);
isk->inet_num = isk->inet_sport = 0;
sock_prot_inuse_add(sock_net(sk), sk->sk_prot, -1);