aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>2013-01-04 23:00:54 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-01-11 09:03:37 -0800
commit611d6f03ec50fe38c6753ada7ffbed3febb862c1 (patch)
tree08ab0f210c262f8946ec0fa23d79c15a2919f7a3
parent42fac8ebfa863c060d2e4613c0a4f8b8fdad8352 (diff)
downloadkernel_samsung_smdk4412-611d6f03ec50fe38c6753ada7ffbed3febb862c1.zip
kernel_samsung_smdk4412-611d6f03ec50fe38c6753ada7ffbed3febb862c1.tar.gz
kernel_samsung_smdk4412-611d6f03ec50fe38c6753ada7ffbed3febb862c1.tar.bz2
ACPI / scan: Do not use dummy HID for system bus ACPI nodes
commit 4f5f64cf0cc916220aaa055992e31195470cfe37 upstream. At one point acpi_device_set_id() checks if acpi_device_hid(device) returns NULL, but that never happens, so system bus devices with an empty list of PNP IDs are given the dummy HID ("device") instead of the "system bus HID" ("LNXSYBUS"). Fix the code to use the right check. Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/acpi/scan.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index 449c556..8cb9742 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -1153,7 +1153,7 @@ static void acpi_device_set_id(struct acpi_device *device)
acpi_add_id(device, ACPI_DOCK_HID);
else if (!acpi_ibm_smbus_match(device))
acpi_add_id(device, ACPI_SMBUS_IBM_HID);
- else if (!acpi_device_hid(device) &&
+ else if (list_empty(&device->pnp.ids) &&
ACPI_IS_ROOT_DEVICE(device->parent)) {
acpi_add_id(device, ACPI_BUS_HID); /* \_SB, LNXSYBUS */
strcpy(device->pnp.device_name, ACPI_BUS_DEVICE_NAME);