diff options
| author | Keerthy <j-keerthy@ti.com> | 2014-11-10 23:49:48 +0530 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2015-02-20 00:49:25 +0000 |
| commit | 3cf6ed7571ec1ad4cbec7ae63fef0288c2370c0b (patch) | |
| tree | 88c5702ab26d709dbe243d0b1654e1b64bbb0b18 /arch/arm | |
| parent | 27bdcd728e8a169fc27c49a7fcf238ca787eedba (diff) | |
| download | kernel_samsung_smdk4412-3cf6ed7571ec1ad4cbec7ae63fef0288c2370c0b.zip kernel_samsung_smdk4412-3cf6ed7571ec1ad4cbec7ae63fef0288c2370c0b.tar.gz kernel_samsung_smdk4412-3cf6ed7571ec1ad4cbec7ae63fef0288c2370c0b.tar.bz2 | |
bus: omap_l3_noc: Correct returning IRQ_HANDLED unconditionally in the irq handler
commit c4cf0935a2d8fe6d186bf4253ea3c4b4a8a8a710 upstream.
Correct returning IRQ_HANDLED unconditionally in the irq handler.
Return IRQ_NONE for some interrupt which we do not expect to be
handled in this handler. This prevents kernel stalling with back
to back spurious interrupts.
Fixes: 2722e56de6 ("OMAP4: l3: Introduce l3-interconnect error handling driver")
Acked-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Keerthy <j-keerthy@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
[bwh: Backported to 3.2: adjust filename, indentation]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'arch/arm')
| -rw-r--r-- | arch/arm/mach-omap2/omap_l3_noc.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/arch/arm/mach-omap2/omap_l3_noc.c b/arch/arm/mach-omap2/omap_l3_noc.c index d15225f..5b9631f 100644 --- a/arch/arm/mach-omap2/omap_l3_noc.c +++ b/arch/arm/mach-omap2/omap_l3_noc.c @@ -121,11 +121,15 @@ static irqreturn_t l3_interrupt_handler(int irq, void *_l3) /* Nothing to be handled here as of now */ break; } - /* Error found so break the for loop */ - break; + /* Error found so break the for loop */ + return IRQ_HANDLED; } } - return IRQ_HANDLED; + + dev_err(l3->dev, "L3 %s IRQ not handled!!\n", + inttype ? "debug" : "application"); + + return IRQ_NONE; } static int __devinit omap4_l3_probe(struct platform_device *pdev) |