diff options
| author | Hemmo Nieminen <hemmo.nieminen@iki.fi> | 2015-01-15 23:01:59 +0200 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2015-03-06 00:39:18 +0000 |
| commit | 7829c20e43e9f915231e8b7c97aaa1acc9133126 (patch) | |
| tree | 3268767b01bb3f52efa9de8569ec387b75010ff3 /arch/mips/kernel/smp.c | |
| parent | eac943e2197b01ae12dd1bbbcf1b7dfb5801f868 (diff) | |
| download | kernel_samsung_smdk4412-7829c20e43e9f915231e8b7c97aaa1acc9133126.zip kernel_samsung_smdk4412-7829c20e43e9f915231e8b7c97aaa1acc9133126.tar.gz kernel_samsung_smdk4412-7829c20e43e9f915231e8b7c97aaa1acc9133126.tar.bz2 | |
MIPS: Fix kernel lockup or crash after CPU offline/online
commit c7754e75100ed5e3068ac5085747f2bfc386c8d6 upstream.
As printk() invocation can cause e.g. a TLB miss, printk() cannot be
called before the exception handlers have been properly initialized.
This can happen e.g. when netconsole has been loaded as a kernel module
and the TLB table has been cleared when a CPU was offline.
Call cpu_report() in start_secondary() only after the exception handlers
have been initialized to fix this.
Without the patch the kernel will randomly either lockup or crash
after a CPU is onlined and the console driver is a module.
Signed-off-by: Hemmo Nieminen <hemmo.nieminen@iki.fi>
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: David Daney <david.daney@cavium.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/8953/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'arch/mips/kernel/smp.c')
| -rw-r--r-- | arch/mips/kernel/smp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c index 32c1e95..bbfae83 100644 --- a/arch/mips/kernel/smp.c +++ b/arch/mips/kernel/smp.c @@ -105,10 +105,10 @@ asmlinkage __cpuinit void start_secondary(void) if ((read_c0_tcbind() & TCBIND_CURTC) == 0) #endif /* CONFIG_MIPS_MT_SMTC */ cpu_probe(); - cpu_report(); per_cpu_trap_init(); mips_clockevent_init(); mp_ops->init_secondary(); + cpu_report(); /* * XXX parity protection should be folded in here when it's converted |