aboutsummaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorRoman Gushchin <klamm@yandex-team.ru>2015-10-12 16:33:44 +0300
committerWolfgang Wiedmeyer <wolfgit@wiedmeyer.de>2016-03-18 01:51:05 +0100
commit993aae88f8995b3597fac88e3f991d22f5f95143 (patch)
tree23858852a25e318ffcb2ea52fd0c347af6691f18 /arch
parentb257e5e6dadaebb880a83db4f5ecab5deededeb6 (diff)
downloadkernel_samsung_smdk4412-993aae88f8995b3597fac88e3f991d22f5f95143.zip
kernel_samsung_smdk4412-993aae88f8995b3597fac88e3f991d22f5f95143.tar.gz
kernel_samsung_smdk4412-993aae88f8995b3597fac88e3f991d22f5f95143.tar.bz2
fuse: break infinite loop in fuse_fill_write_pages()
I got a report about unkillable task eating CPU. Further investigation shows, that the problem is in the fuse_fill_write_pages() function. If iov's first segment has zero length, we get an infinite loop, because we never reach iov_iter_advance() call. Fix this by calling iov_iter_advance() before repeating an attempt to copy data from userspace. A similar problem is described in 124d3b7041f ("fix writev regression: pan hanging unkillable and un-straceable"). If zero-length segmend is followed by segment with invalid address, iov_iter_fault_in_readable() checks only first segment (zero-length), iov_iter_copy_from_user_atomic() skips it, fails at second and returns zero -> goto again without skipping zero-length segment. Patch calls iov_iter_advance() before goto again: we'll skip zero-length segment at second iteraction and iov_iter_fault_in_readable() will detect invalid address. Special thanks to Konstantin Khlebnikov, who helped a lot with the commit description. Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Maxim Patlasov <mpatlasov@parallels.com> Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> Signed-off-by: Roman Gushchin <klamm@yandex-team.ru> Signed-off-by: Miklos Szeredi <miklos@szeredi.hu> Fixes: ea9b9907b82a ("fuse: implement perform_write") Cc: <stable@vger.kernel.org> Conflicts: fs/fuse/file.c Change-Id: Id37193373294dd43191469389cfe68ca1736a54b
Diffstat (limited to 'arch')
0 files changed, 0 insertions, 0 deletions