diff options
| author | Kees Cook <keescook@chromium.org> | 2013-07-03 15:01:14 -0700 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2013-07-27 05:34:28 +0100 |
| commit | b442223040adf969fd02124c29c856a06cf5649c (patch) | |
| tree | d11c367a98796d87a291b3eb36665ba8a0c11c89 /block | |
| parent | 93f26306db89c9dc37885b76a1082e6d54d23b16 (diff) | |
| download | kernel_samsung_smdk4412-b442223040adf969fd02124c29c856a06cf5649c.zip kernel_samsung_smdk4412-b442223040adf969fd02124c29c856a06cf5649c.tar.gz kernel_samsung_smdk4412-b442223040adf969fd02124c29c856a06cf5649c.tar.bz2 | |
block: do not pass disk names as format strings
commit ffc8b30866879ed9ba62bd0a86fecdbd51cd3d19 upstream.
Disk names may contain arbitrary strings, so they must not be
interpreted as format strings. It seems that only md allows arbitrary
strings to be used for disk names, but this could allow for a local
memory corruption from uid 0 into ring 0.
CVE-2013-2851
Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[bwh: Backported to 3.2: adjust device pointer name in nbd.c]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'block')
| -rw-r--r-- | block/genhd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/block/genhd.c b/block/genhd.c index 6edf228..8bd4ef2 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -519,7 +519,7 @@ void register_disk(struct gendisk *disk) ddev->parent = disk->driverfs_dev; - dev_set_name(ddev, disk->disk_name); + dev_set_name(ddev, "%s", disk->disk_name); /* delay uevents, until we scanned partition table */ dev_set_uevent_suppress(ddev, 1); |