diff options
author | Vladis Dronov <vdronov@redhat.com> | 2016-03-31 12:05:43 -0400 |
---|---|---|
committer | Simon Shields <keepcalm444@gmail.com> | 2016-11-11 13:26:51 +1100 |
commit | 4c72b649cb557ff8b613b94bd68471ecfb42f0fb (patch) | |
tree | be973a58f8ba162d20a0d9e6218a22ba799fd775 /crypto/serpent.c | |
parent | 60117f1016086f658c7d765a7f928e217699dbc4 (diff) | |
download | kernel_samsung_smdk4412-4c72b649cb557ff8b613b94bd68471ecfb42f0fb.zip kernel_samsung_smdk4412-4c72b649cb557ff8b613b94bd68471ecfb42f0fb.tar.gz kernel_samsung_smdk4412-4c72b649cb557ff8b613b94bd68471ecfb42f0fb.tar.bz2 |
ALSA: usb-audio: Fix double-free in error paths after snd_usb_add_audio_stream() call
commit 836b34a935abc91e13e63053d0a83b24dfb5ea78 upstream.
create_fixed_stream_quirk(), snd_usb_parse_audio_interface() and
create_uaxx_quirk() functions allocate the audioformat object by themselves
and free it upon error before returning. However, once the object is linked
to a stream, it's freed again in snd_usb_audio_pcm_free(), thus it'll be
double-freed, eventually resulting in a memory corruption.
This patch fixes these failures in the error paths by unlinking the audioformat
object before freeing it.
Based on a patch by Takashi Iwai <tiwai@suse.de>
[Note for stable backports:
this patch requires the commit 902eb7fd1e4a ('ALSA: usb-audio: Minor
code cleanup in create_fixed_stream_quirk()')]
Change-Id: Ia332409f06bbd20c0abf9cf915f4a041200e4736
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1283358
Reported-by: Ralf Spenneberg <ralf@spenneberg.net>
Signed-off-by: Vladis Dronov <vdronov@redhat.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'crypto/serpent.c')
0 files changed, 0 insertions, 0 deletions