aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/ata
diff options
context:
space:
mode:
authorAnton Blanchard <anton@samba.org>2007-10-26 13:59:44 +0200
committerJens Axboe <jens.axboe@oracle.com>2007-10-29 09:18:03 +0100
commitacd054a5ef401e03e0047b487e572442614f81e5 (patch)
tree000704c359643885e3b0fd4e6d082321d5889ccb /drivers/ata
parent5336940dd8b11180a0340ba886db62f728377d19 (diff)
downloadkernel_samsung_smdk4412-acd054a5ef401e03e0047b487e572442614f81e5.zip
kernel_samsung_smdk4412-acd054a5ef401e03e0047b487e572442614f81e5.tar.gz
kernel_samsung_smdk4412-acd054a5ef401e03e0047b487e572442614f81e5.tar.bz2
Initialise scatter/gather list in ata_sg_setup
After turning on DEBUG_SG I hit a fail: kernel BUG at include/linux/scatterlist.h:50! ata_qc_issue ata_scsi_translate ipr_queuecommand scsi_dispatch_cmd scsi_request_fn elv_insert blk_execute_rq_nowait blk_execute_rq sg_io scsi_cmd_ioctl cdrom_ioctl sr_block_ioctl blkdev_driver_ioctl blkdev_ioctl block_ioctl do_ioctl vfs_ioctl sys_ioctl sg_ioctl_trans It looks like ata_sg_setup is working on an uninitialised sg table. Call sg_init_table to initialise it before use. Signed-off-by: Anton Blanchard <anton@samba.org> Note: this patch will fix it, but you could also get away with just doing the sg_init_table() once at qc creation time. Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'drivers/ata')
-rw-r--r--drivers/ata/libata-core.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 081e3df..7ef515b 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4689,6 +4689,7 @@ static int ata_sg_setup(struct ata_queued_cmd *qc)
* data in this function or read data in ata_sg_clean.
*/
offset = lsg->offset + lsg->length - qc->pad_len;
+ sg_init_table(psg, 1);
sg_set_page(psg, nth_page(sg_page(lsg), offset >> PAGE_SHIFT),
qc->pad_len, offset_in_page(offset));