diff options
| author | Jonathan Corbet <corbet@lwn.net> | 2008-05-18 15:32:43 -0600 |
|---|---|---|
| committer | Jonathan Corbet <corbet@lwn.net> | 2008-06-20 14:05:53 -0600 |
| commit | f2b9857eee17797541b845782ade4d7a9d50f843 (patch) | |
| tree | 914a00afee2ff953199f99f7cf869e3fd83b36bd /drivers/char/scx200_gpio.c | |
| parent | 0b2806768899dba5967bcd4a3b93eaed9a1dc4f3 (diff) | |
| download | kernel_samsung_smdk4412-f2b9857eee17797541b845782ade4d7a9d50f843.zip kernel_samsung_smdk4412-f2b9857eee17797541b845782ade4d7a9d50f843.tar.gz kernel_samsung_smdk4412-f2b9857eee17797541b845782ade4d7a9d50f843.tar.bz2 | |
Add a bunch of cycle_kernel_lock() calls
All of the open() functions which don't need the BKL on their face may
still depend on its acquisition to serialize opens against driver
initialization. So make those functions acquire then release the BKL to be
on the safe side.
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Diffstat (limited to 'drivers/char/scx200_gpio.c')
| -rw-r--r-- | drivers/char/scx200_gpio.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/char/scx200_gpio.c b/drivers/char/scx200_gpio.c index be2c623..1d91005 100644 --- a/drivers/char/scx200_gpio.c +++ b/drivers/char/scx200_gpio.c @@ -12,6 +12,7 @@ #include <linux/kernel.h> #include <linux/init.h> #include <linux/platform_device.h> +#include <linux/smp_lock.h> #include <asm/uaccess.h> #include <asm/io.h> @@ -46,12 +47,12 @@ struct nsc_gpio_ops scx200_gpio_ops = { }; EXPORT_SYMBOL_GPL(scx200_gpio_ops); -/* No BKL needed here: no global resources used */ static int scx200_gpio_open(struct inode *inode, struct file *file) { unsigned m = iminor(inode); file->private_data = &scx200_gpio_ops; + cycle_kernel_lock(); if (m >= MAX_PINS) return -EINVAL; return nonseekable_open(inode, file); |