diff options
| author | Kees Cook <keescook@chromium.org> | 2013-05-12 22:00:51 -0700 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2013-05-30 14:34:57 +0100 |
| commit | 05172d75318ab9c583895576acb24c62382f60fe (patch) | |
| tree | a4cada3e79738a5ffed6145135214d1973145c93 /drivers/gpu | |
| parent | 694da87f929f867afe14efcc5683bc652dca4da8 (diff) | |
| download | kernel_samsung_smdk4412-05172d75318ab9c583895576acb24c62382f60fe.zip kernel_samsung_smdk4412-05172d75318ab9c583895576acb24c62382f60fe.tar.gz kernel_samsung_smdk4412-05172d75318ab9c583895576acb24c62382f60fe.tar.bz2 | |
drm/radeon: check incoming cliprects pointer
commit fefaedcfb82d2e57c2320acf60604ab03b750cc0 upstream.
The "boxes" parameter points into userspace memory. It should be verified
like any other operation against user memory.
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'drivers/gpu')
| -rw-r--r-- | drivers/gpu/drm/radeon/r300_cmdbuf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/radeon/r300_cmdbuf.c b/drivers/gpu/drm/radeon/r300_cmdbuf.c index 1fe98b4..9aa02be 100644 --- a/drivers/gpu/drm/radeon/r300_cmdbuf.c +++ b/drivers/gpu/drm/radeon/r300_cmdbuf.c @@ -74,7 +74,7 @@ static int r300_emit_cliprects(drm_radeon_private_t *dev_priv, OUT_RING(CP_PACKET0(R300_RE_CLIPRECT_TL_0, nr * 2 - 1)); for (i = 0; i < nr; ++i) { - if (DRM_COPY_FROM_USER_UNCHECKED + if (DRM_COPY_FROM_USER (&box, &cmdbuf->boxes[n + i], sizeof(box))) { DRM_ERROR("copy cliprect faulted\n"); return -EFAULT; |