aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/hwmon
diff options
context:
space:
mode:
authorJean Delvare <khali@linux-fr.org>2012-01-20 10:09:23 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-02-03 09:19:01 -0800
commitc39714f1da06b21e4d4250d030448099912ae79f (patch)
tree5298e692d639e97d0540413d3d66d4409b857d63 /drivers/hwmon
parentdd5a1b14d8c2f6ca3692aa4d829aa4afb1319f0e (diff)
downloadkernel_samsung_smdk4412-c39714f1da06b21e4d4250d030448099912ae79f.zip
kernel_samsung_smdk4412-c39714f1da06b21e4d4250d030448099912ae79f.tar.gz
kernel_samsung_smdk4412-c39714f1da06b21e4d4250d030448099912ae79f.tar.bz2
hwmon: (f71805f) Fix clamping of temperature limits
commit 86b2bbfdbd1fcc4a3aa62ccd3f245c40c5ad5b85 upstream. Properly clamp temperature limits set by the user. Without this fix, attempts to write temperature limits above the maximum supported by the chip (255 degrees Celsius) would arbitrarily and unexpectedly result in the limit being set to 0 degree Celsius. Signed-off-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/hwmon')
-rw-r--r--drivers/hwmon/f71805f.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/hwmon/f71805f.c b/drivers/hwmon/f71805f.c
index 92f9497..6dbfd3e 100644
--- a/drivers/hwmon/f71805f.c
+++ b/drivers/hwmon/f71805f.c
@@ -283,11 +283,11 @@ static inline long temp_from_reg(u8 reg)
static inline u8 temp_to_reg(long val)
{
- if (val < 0)
- val = 0;
- else if (val > 1000 * 0xff)
- val = 0xff;
- return ((val + 500) / 1000);
+ if (val <= 0)
+ return 0;
+ if (val >= 1000 * 0xff)
+ return 0xff;
+ return (val + 500) / 1000;
}
/*