diff options
| author | Axel Lin <axel.lin@gmail.com> | 2011-12-08 08:04:12 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-12-21 12:57:39 -0800 |
| commit | cadacbdef368bb32b8da3e9b46fc2a4b2ba751c7 (patch) | |
| tree | 7ff93bfb7668443cbbf3a2e6537a217dfe17593e /drivers/hwmon | |
| parent | c1f95ce58fb4257de087ab89343adea9a47c2144 (diff) | |
| download | kernel_samsung_smdk4412-cadacbdef368bb32b8da3e9b46fc2a4b2ba751c7.zip kernel_samsung_smdk4412-cadacbdef368bb32b8da3e9b46fc2a4b2ba751c7.tar.gz kernel_samsung_smdk4412-cadacbdef368bb32b8da3e9b46fc2a4b2ba751c7.tar.bz2 | |
hwmon: (jz4740) fix signedness bug
commit 0b57d7602b68f7b2786b2f0e22da39cbd4139a95 upstream.
wait_for_completion_interruptible_timeout() may return negative value.
In this case, checking if (t > 0) will return true if t is unsigned.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/jz4740-hwmon.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/jz4740-hwmon.c b/drivers/hwmon/jz4740-hwmon.c index fea292d..b65a4da 100644 --- a/drivers/hwmon/jz4740-hwmon.c +++ b/drivers/hwmon/jz4740-hwmon.c @@ -59,7 +59,7 @@ static ssize_t jz4740_hwmon_read_adcin(struct device *dev, { struct jz4740_hwmon *hwmon = dev_get_drvdata(dev); struct completion *completion = &hwmon->read_completion; - unsigned long t; + long t; unsigned long val; int ret; |