aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/iommu
diff options
context:
space:
mode:
authorBenjamin Randazzo <benjamin@randazzo.fr>2015-07-25 16:36:50 +0200
committerBen Hutchings <ben@decadent.org.uk>2015-10-13 03:46:11 +0100
commit06f0f9d843af52573c7dad0d81ee9df984e0b6be (patch)
tree08c844bca6f240fbe54b9a9b7be9315e49c475df /drivers/iommu
parentcbea57119272755ccfd710fdaf4669ae05512b02 (diff)
downloadkernel_samsung_smdk4412-06f0f9d843af52573c7dad0d81ee9df984e0b6be.zip
kernel_samsung_smdk4412-06f0f9d843af52573c7dad0d81ee9df984e0b6be.tar.gz
kernel_samsung_smdk4412-06f0f9d843af52573c7dad0d81ee9df984e0b6be.tar.bz2
md: use kzalloc() when bitmap is disabled
commit b6878d9e03043695dbf3fa1caa6dfc09db225b16 upstream. In drivers/md/md.c get_bitmap_file() uses kmalloc() for creating a mdu_bitmap_file_t called "file". 5769 file = kmalloc(sizeof(*file), GFP_NOIO); 5770 if (!file) 5771 return -ENOMEM; This structure is copied to user space at the end of the function. 5786 if (err == 0 && 5787 copy_to_user(arg, file, sizeof(*file))) 5788 err = -EFAULT But if bitmap is disabled only the first byte of "file" is initialized with zero, so it's possible to read some bytes (up to 4095) of kernel space memory from user space. This is an information leak. 5775 /* bitmap disabled, zero the first byte and copy out */ 5776 if (!mddev->bitmap_info.file) 5777 file->pathname[0] = '\0'; Signed-off-by: Benjamin Randazzo <benjamin@randazzo.fr> Signed-off-by: NeilBrown <neilb@suse.com> [bwh: Backported to 3.2: patch both possible allocation calls] Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'drivers/iommu')
0 files changed, 0 insertions, 0 deletions