diff options
| author | Tilman Schmidt <tilman@imap.cc> | 2013-01-21 11:57:21 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-02-14 10:47:34 -0800 |
| commit | 71d6857a18388acba0e84213778f0efba089d15f (patch) | |
| tree | cec8351656a05e092fb57a35dd1ead3d9122343b /drivers/isdn | |
| parent | 6856b63b31aed9e2d3a42f2d8c7f75dbdecd4f69 (diff) | |
| download | kernel_samsung_smdk4412-71d6857a18388acba0e84213778f0efba089d15f.zip kernel_samsung_smdk4412-71d6857a18388acba0e84213778f0efba089d15f.tar.gz kernel_samsung_smdk4412-71d6857a18388acba0e84213778f0efba089d15f.tar.bz2 | |
isdn/gigaset: fix zero size border case in debug dump
[ Upstream commit d721a1752ba544df8d7d36959038b26bc92bdf80 ]
If subtracting 12 from l leaves zero we'd do a zero size allocation,
leading to an oops later when we try to set the NUL terminator.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/isdn')
| -rw-r--r-- | drivers/isdn/gigaset/capi.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/isdn/gigaset/capi.c b/drivers/isdn/gigaset/capi.c index d1dde65..483ac00 100644 --- a/drivers/isdn/gigaset/capi.c +++ b/drivers/isdn/gigaset/capi.c @@ -263,6 +263,8 @@ static inline void dump_rawmsg(enum debuglevel level, const char *tag, CAPIMSG_APPID(data), CAPIMSG_MSGID(data), l, CAPIMSG_CONTROL(data)); l -= 12; + if (l <= 0) + return; dbgline = kmalloc(3*l, GFP_ATOMIC); if (!dbgline) return; |