diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2011-09-29 02:09:42 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2011-09-30 13:32:00 -0300 |
| commit | 4c4364e022f8422e602edbb97a2d873dc0b6c769 (patch) | |
| tree | 664c96efee5d6e5d83c0e788a40b68bc71e606c7 /drivers/media/dvb/dvb-usb/mxl111sf-i2c.c | |
| parent | 446b792c6bd87de4565ba200b75a708b4c575a06 (diff) | |
| download | kernel_samsung_smdk4412-4c4364e022f8422e602edbb97a2d873dc0b6c769.zip kernel_samsung_smdk4412-4c4364e022f8422e602edbb97a2d873dc0b6c769.tar.gz kernel_samsung_smdk4412-4c4364e022f8422e602edbb97a2d873dc0b6c769.tar.bz2 | |
[media] mxl111sf: fix a couple precedence bugs
Negate has higher precedence than bitwise AND. I2C_M_RD is 0x1 so
the original code is equivelent to just checking if (!msg->flags).
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Steven Toth <stoth@kernellabs.com>
Cc: Michael Krufky <mkrufky@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/dvb/dvb-usb/mxl111sf-i2c.c')
| -rw-r--r-- | drivers/media/dvb/dvb-usb/mxl111sf-i2c.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/media/dvb/dvb-usb/mxl111sf-i2c.c b/drivers/media/dvb/dvb-usb/mxl111sf-i2c.c index a330987..2e8c288 100644 --- a/drivers/media/dvb/dvb-usb/mxl111sf-i2c.c +++ b/drivers/media/dvb/dvb-usb/mxl111sf-i2c.c @@ -453,7 +453,7 @@ static int mxl111sf_i2c_hw_xfer_msg(struct mxl111sf_state *state, mxl_i2c("addr: 0x%02x, read buff len: %d, write buff len: %d", msg->addr, (msg->flags & I2C_M_RD) ? msg->len : 0, - (!msg->flags & I2C_M_RD) ? msg->len : 0); + (!(msg->flags & I2C_M_RD)) ? msg->len : 0); for (index = 0; index < 26; index++) buf[index] = USB_END_I2C_CMD; @@ -489,7 +489,7 @@ static int mxl111sf_i2c_hw_xfer_msg(struct mxl111sf_state *state, ret = mxl111sf_i2c_send_data(state, 0, buf); /* write data on I2C bus */ - if ((!msg->flags & I2C_M_RD) && (msg->len > 0)) { + if (!(msg->flags & I2C_M_RD) && (msg->len > 0)) { mxl_i2c("%d\t%02x", msg->len, msg->buf[0]); /* control register on I2C interface to initialize I2C bus */ |