diff options
author | Xi Wang <xi.wang@gmail.com> | 2012-02-14 14:32:41 -0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-04-02 09:27:18 -0700 |
commit | 88a782d295e29051e1da10a097ff72b3918dbaa9 (patch) | |
tree | e78a195800a8b3827917e86901640dacdca19f43 /drivers/media/dvb/firewire | |
parent | 7d088dca7920bc7c5d74d6c430699abb63ec0151 (diff) | |
download | kernel_samsung_smdk4412-88a782d295e29051e1da10a097ff72b3918dbaa9.zip kernel_samsung_smdk4412-88a782d295e29051e1da10a097ff72b3918dbaa9.tar.gz kernel_samsung_smdk4412-88a782d295e29051e1da10a097ff72b3918dbaa9.tar.bz2 |
lgdt330x: fix signedness error in i2c_read_demod_bytes()
commit 34817174fca0c5512c2d5b6ea0fc37a0337ce1d8 upstream.
The error handling in lgdt3303_read_status() and lgdt330x_read_ucblocks()
doesn't work, because i2c_read_demod_bytes() returns a u8 and (err < 0)
is always false.
err = i2c_read_demod_bytes(state, 0x58, buf, 1);
if (err < 0)
return err;
Change the return type of i2c_read_demod_bytes() to int. Also change
the return value on error to -EIO to make (err < 0) work.
Signed-off-by: Xi Wang <xi.wang@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/media/dvb/firewire')
0 files changed, 0 insertions, 0 deletions