aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/video/saa7127.c
diff options
context:
space:
mode:
authorHans Verkuil <hverkuil@xs4all.nl>2007-09-16 10:47:15 -0300
committerMauro Carvalho Chehab <mchehab@infradead.org>2008-01-25 19:01:27 -0200
commit188f3457c21ac7869005021b56b4578293c644bb (patch)
tree7002562a01698d2fa6070f1547e609f9b29cb163 /drivers/media/video/saa7127.c
parent6235168db8ed96c587e566be0dd72a77ca212693 (diff)
downloadkernel_samsung_smdk4412-188f3457c21ac7869005021b56b4578293c644bb.zip
kernel_samsung_smdk4412-188f3457c21ac7869005021b56b4578293c644bb.tar.gz
kernel_samsung_smdk4412-188f3457c21ac7869005021b56b4578293c644bb.tar.bz2
V4L/DVB (6465): Use correct error codes when chip is not recognized
If the chip isn't recognized, then the correct errors should be returned. The v4l2_i2c_attach() utility function will return 0 for all errors except -ENOMEM to provide proper compatibility support for the old I2C probing function. Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Diffstat (limited to 'drivers/media/video/saa7127.c')
-rw-r--r--drivers/media/video/saa7127.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/media/video/saa7127.c b/drivers/media/video/saa7127.c
index 958ecc7..0262acd 100644
--- a/drivers/media/video/saa7127.c
+++ b/drivers/media/video/saa7127.c
@@ -671,7 +671,7 @@ static int saa7127_probe(struct i2c_client *client)
/* Check if the adapter supports the needed features */
if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_BYTE_DATA))
- return 0;
+ return -EIO;
snprintf(client->name, sizeof(client->name) - 1, "saa7127");
@@ -685,12 +685,12 @@ static int saa7127_probe(struct i2c_client *client)
if ((saa7127_read(client, 0) & 0xe4) != 0 ||
(saa7127_read(client, 0x29) & 0x3f) != 0x1d) {
v4l_dbg(1, debug, client, "saa7127 not found\n");
- return 0;
+ return -ENODEV;
}
state = kzalloc(sizeof(struct saa7127_state), GFP_KERNEL);
if (state == NULL) {
- return (-ENOMEM);
+ return -ENOMEM;
}
i2c_set_clientdata(client, state);