aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/mfd
diff options
context:
space:
mode:
authorLinus Walleij <linus.walleij@stericsson.com>2010-05-28 02:59:44 +0200
committerSamuel Ortiz <sameo@linux.intel.com>2010-08-12 11:27:18 +0200
commitc0d4010e11e23d6f55f9bdda63b1974f35af71bf (patch)
tree862ea68bf95e6f8d57d8a94c2b24d1c48ff9298b /drivers/mfd
parenteb6e8ddf06ff0d6b6548ca0b95a4edfeb2aaadd0 (diff)
downloadkernel_samsung_smdk4412-c0d4010e11e23d6f55f9bdda63b1974f35af71bf.zip
kernel_samsung_smdk4412-c0d4010e11e23d6f55f9bdda63b1974f35af71bf.tar.gz
kernel_samsung_smdk4412-c0d4010e11e23d6f55f9bdda63b1974f35af71bf.tar.bz2
mfd: AB8500 mask off irrelevant bits from the SPI message
The registers on the AB8500 are only 8 bits wide, so the content of the remaining bits is undefined. Let's mask off the undefined stuff when returning a register in an SPI read. Acked-by: Rabin Vincent <rabin.vincent@stericsson.com> Signed-off-by: Linus Walleij <linus.walleij@stericsson.com> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Diffstat (limited to 'drivers/mfd')
-rw-r--r--drivers/mfd/ab8500-spi.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/mfd/ab8500-spi.c b/drivers/mfd/ab8500-spi.c
index b81d4f7..e1c8b62 100644
--- a/drivers/mfd/ab8500-spi.c
+++ b/drivers/mfd/ab8500-spi.c
@@ -68,7 +68,12 @@ static int ab8500_spi_read(struct ab8500 *ab8500, u16 addr)
ret = spi_sync(spi, &msg);
if (!ret)
- ret = ab8500->rx_buf[0];
+ /*
+ * Only the 8 lowermost bytes are
+ * defined with value, the rest may
+ * vary depending on chip/board noise.
+ */
+ ret = ab8500->rx_buf[0] & 0xFFU;
return ret;
}