diff options
| author | Artem Bityutskiy <Artem.Bityutskiy@nokia.com> | 2008-06-04 16:48:12 +0300 |
|---|---|---|
| committer | Artem Bityutskiy <Artem.Bityutskiy@nokia.com> | 2008-07-24 13:32:54 +0300 |
| commit | abc5e92262d87f9c5c628492bffc55f81c7dcb80 (patch) | |
| tree | ad33229247f99996dd875e68c10dcef9d1d40519 /drivers/mtd/ubi/eba.c | |
| parent | cadb40ccc16a26a738f1cbc963e35b21edd93e79 (diff) | |
| download | kernel_samsung_smdk4412-abc5e92262d87f9c5c628492bffc55f81c7dcb80.zip kernel_samsung_smdk4412-abc5e92262d87f9c5c628492bffc55f81c7dcb80.tar.gz kernel_samsung_smdk4412-abc5e92262d87f9c5c628492bffc55f81c7dcb80.tar.bz2 | |
UBI: fix memory leak
ubi_free_volume() function sets ubi->volumes[] to NULL, so
ubi_eba_close() is useless, it does not free what has to be freed.
So zap it and free vol->eba_tbl at the volume release function.
Pointed-out-by: Adrian Hunter <ext-adrian.hunter@nokia.com>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Diffstat (limited to 'drivers/mtd/ubi/eba.c')
| -rw-r--r-- | drivers/mtd/ubi/eba.c | 17 |
1 files changed, 0 insertions, 17 deletions
diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c index 37d7784..623d25f 100644 --- a/drivers/mtd/ubi/eba.c +++ b/drivers/mtd/ubi/eba.c @@ -1233,20 +1233,3 @@ out_free: } return err; } - -/** - * ubi_eba_close - close EBA unit. - * @ubi: UBI device description object - */ -void ubi_eba_close(const struct ubi_device *ubi) -{ - int i, num_volumes = ubi->vtbl_slots + UBI_INT_VOL_COUNT; - - dbg_eba("close EBA unit"); - - for (i = 0; i < num_volumes; i++) { - if (!ubi->volumes[i]) - continue; - kfree(ubi->volumes[i]->eba_tbl); - } -} |