aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/sfc
diff options
context:
space:
mode:
authorBen Hutchings <bhutchings@solarflare.com>2010-04-28 09:28:36 +0000
committerDavid S. Miller <davem@davemloft.net>2010-04-28 12:44:36 -0700
commitb548a988a9d08f2b06f6810b1a4cde6f632bd307 (patch)
tree6533b6eaa30cc549ed131f69b4830594b0dcbf6d /drivers/net/sfc
parent41b7e4c3268d9d2056b9c94cceb386649f7b185b (diff)
downloadkernel_samsung_smdk4412-b548a988a9d08f2b06f6810b1a4cde6f632bd307.zip
kernel_samsung_smdk4412-b548a988a9d08f2b06f6810b1a4cde6f632bd307.tar.gz
kernel_samsung_smdk4412-b548a988a9d08f2b06f6810b1a4cde6f632bd307.tar.bz2
sfc: Log specific message for failure of NVRAM self-test
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/sfc')
-rw-r--r--drivers/net/sfc/mcdi.c10
1 files changed, 8 insertions, 2 deletions
diff --git a/drivers/net/sfc/mcdi.c b/drivers/net/sfc/mcdi.c
index 1344afa..93cc3c1 100644
--- a/drivers/net/sfc/mcdi.c
+++ b/drivers/net/sfc/mcdi.c
@@ -932,20 +932,26 @@ int efx_mcdi_nvram_test_all(struct efx_nic *efx)
rc = efx_mcdi_nvram_types(efx, &nvram_types);
if (rc)
- return rc;
+ goto fail1;
type = 0;
while (nvram_types != 0) {
if (nvram_types & 1) {
rc = efx_mcdi_nvram_test(efx, type);
if (rc)
- return rc;
+ goto fail2;
}
type++;
nvram_types >>= 1;
}
return 0;
+
+fail2:
+ EFX_ERR(efx, "%s: failed type=%u\n", __func__, type);
+fail1:
+ EFX_ERR(efx, "%s: failed rc=%d\n", __func__, rc);
+ return rc;
}
static int efx_mcdi_read_assertion(struct efx_nic *efx)