aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/regulator
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@gmail.com>2011-05-18 20:56:45 +0800
committerLiam Girdwood <lrg@slimlogic.co.uk>2011-05-27 10:49:10 +0100
commit3c24019ddeab71ddf125ad2ad13a38041655c1fd (patch)
tree69019327c70fbc3b160164884f6f333cd4abf5f5 /drivers/regulator
parent6dc4efc6d5429292f29009f6569fbb9a53929dd6 (diff)
downloadkernel_samsung_smdk4412-3c24019ddeab71ddf125ad2ad13a38041655c1fd.zip
kernel_samsung_smdk4412-3c24019ddeab71ddf125ad2ad13a38041655c1fd.tar.gz
kernel_samsung_smdk4412-3c24019ddeab71ddf125ad2ad13a38041655c1fd.tar.bz2
regulator: Fix off-by-one value range checking for mc13xxx_regulator_get_voltage
We use val as array index, thus the valid value rangae for val should be 0 .. n_voltages-1. Signed-off-by: Axel Lin <axel.lin@gmail.com> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
Diffstat (limited to 'drivers/regulator')
-rw-r--r--drivers/regulator/mc13xxx-regulator-core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/regulator/mc13xxx-regulator-core.c b/drivers/regulator/mc13xxx-regulator-core.c
index 2bb5de1..bc27ab1 100644
--- a/drivers/regulator/mc13xxx-regulator-core.c
+++ b/drivers/regulator/mc13xxx-regulator-core.c
@@ -174,7 +174,7 @@ static int mc13xxx_regulator_get_voltage(struct regulator_dev *rdev)
dev_dbg(rdev_get_dev(rdev), "%s id: %d val: %d\n", __func__, id, val);
- BUG_ON(val > mc13xxx_regulators[id].desc.n_voltages);
+ BUG_ON(val >= mc13xxx_regulators[id].desc.n_voltages);
return mc13xxx_regulators[id].voltages[val];
}