diff options
author | Daniel Walker <dwalker@mvista.com> | 2006-06-25 05:47:37 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-06-25 10:01:05 -0700 |
commit | dcd96379613a3cbe87c30e1c20122ecdcdf3a4b8 (patch) | |
tree | a993e3a14340feb966312078c79e7b9fc1bddbb3 /drivers/rtc/rtc-pl031.c | |
parent | a04ee14636fa339c4609766bd6173629d4f9026e (diff) | |
download | kernel_samsung_smdk4412-dcd96379613a3cbe87c30e1c20122ecdcdf3a4b8.zip kernel_samsung_smdk4412-dcd96379613a3cbe87c30e1c20122ecdcdf3a4b8.tar.gz kernel_samsung_smdk4412-dcd96379613a3cbe87c30e1c20122ecdcdf3a4b8.tar.bz2 |
[PATCH] idetape gcc 4.1 warning fix
In both the read and write cases it will return an error if
copy_{from/to}_user faults. However, I let the driver try to read/write as
much as it can just as it normally would , then finally it returns an error
if there was one. This was the most straight forward way to handle the
error , since there isn't a clear way to clean up the buffers on error .
I moved retval in idetape_chrdev_write() down into the actual code blocks
since it's really once used there, and it conflicted with my ret variable.
Fixes the following warning,
drivers/ide/ide-tape.c: In function âidetape_copy_stage_from_userâ:
drivers/ide/ide-tape.c:2662: warning: ignoring return value of âcopy_from_userâ, declared with attribute warn_unused_result
drivers/ide/ide-tape.c: In function âidetape_copy_stage_to_userâ:
drivers/ide/ide-tape.c:2689: warning: ignoring return value of âcopy_to_userâ, declared with attribute warn_unused_result
Signed-off-by: Daniel Walker <dwalker@mvista.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/rtc/rtc-pl031.c')
0 files changed, 0 insertions, 0 deletions