diff options
| author | Kulikov Vasiliy <segooon@gmail.com> | 2010-08-03 19:44:20 +0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-08-31 11:13:57 -0700 |
| commit | 13b631a599cddabc1cbb3a2fb862aee5ceb6e427 (patch) | |
| tree | 7282d0acf5ea7cd0e37fbd669e5da61b87d66c8c /drivers/staging/vt6655 | |
| parent | bd2bc4c763db8a9c6eeef0d2cf6f384514b6cb6c (diff) | |
| download | kernel_samsung_smdk4412-13b631a599cddabc1cbb3a2fb862aee5ceb6e427.zip kernel_samsung_smdk4412-13b631a599cddabc1cbb3a2fb862aee5ceb6e427.tar.gz kernel_samsung_smdk4412-13b631a599cddabc1cbb3a2fb862aee5ceb6e427.tar.bz2 | |
staging: vt6655: do not use PCI resources before pci_enable_device()
IRQ and resource[] may not have correct values until
after PCI hotplug setup occurs at pci_enable_device() time.
The semantic match that finds this problem is as follows:
// <smpl>
@@
identifier x;
identifier request ~= "pci_request.*|pci_resource.*";
@@
(
* x->irq
|
* x->resource
|
* request(x, ...)
)
...
*pci_enable_device(x)
// </smpl>
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/vt6655')
| -rw-r--r-- | drivers/staging/vt6655/device_main.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c index 4d6b66a..f5028d9 100644 --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -955,12 +955,13 @@ vt6655_probe(struct pci_dev *pcid, const struct pci_device_id *ent) pDevice->dev = dev; pDevice->next_module = root_device_dev; root_device_dev = dev; - dev->irq = pcid->irq; if (pci_enable_device(pcid)) { device_free_info(pDevice); return -ENODEV; } + dev->irq = pcid->irq; + #ifdef DEBUG printk("Before get pci_info memaddr is %x\n",pDevice->memaddr); #endif |