aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/target
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@infradead.org>2012-09-26 08:00:37 -0400
committerBen Hutchings <ben@decadent.org.uk>2012-10-17 03:49:25 +0100
commit5b84d8279eb9fa68c1e8eb3e79cf1e42607dfd1e (patch)
treed4b56666a0d52a18df96c9462dd87cb66d8794be /drivers/target
parent0450a208da987620b839d0eecd6dbf3bb50b38e8 (diff)
downloadkernel_samsung_smdk4412-5b84d8279eb9fa68c1e8eb3e79cf1e42607dfd1e.zip
kernel_samsung_smdk4412-5b84d8279eb9fa68c1e8eb3e79cf1e42607dfd1e.tar.gz
kernel_samsung_smdk4412-5b84d8279eb9fa68c1e8eb3e79cf1e42607dfd1e.tar.bz2
iscsit: remove incorrect unlock in iscsit_build_sendtargets_resp
commit 904753da183566c71211d23c169a80184648c121 upstream. Fix a potential multiple spin-unlock -> deadlock scenario during the overflow check within iscsit_build_sendtargets_resp() as found by sparse static checking. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'drivers/target')
-rw-r--r--drivers/target/iscsi/iscsi_target.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
index 81cf25f..f35cb10 100644
--- a/drivers/target/iscsi/iscsi_target.c
+++ b/drivers/target/iscsi/iscsi_target.c
@@ -3204,7 +3204,6 @@ static int iscsit_build_sendtargets_response(struct iscsi_cmd *cmd)
len += 1;
if ((len + payload_len) > buffer_len) {
- spin_unlock(&tiqn->tiqn_tpg_lock);
end_of_buf = 1;
goto eob;
}