diff options
| author | Dan Carpenter <error27@gmail.com> | 2011-03-17 22:39:49 +0300 |
|---|---|---|
| committer | Sarah Sharp <sarah.a.sharp@linux.intel.com> | 2011-04-13 16:19:47 -0700 |
| commit | 22e0487047567252d5677ff35766cd884375efc2 (patch) | |
| tree | 792d135afe30d6af87d38ff5a8eb010d39c86053 /drivers/usb/host/xhci-ring.c | |
| parent | 5a6c2f3ff039154872ce597952f8b8900ea0d732 (diff) | |
| download | kernel_samsung_smdk4412-22e0487047567252d5677ff35766cd884375efc2.zip kernel_samsung_smdk4412-22e0487047567252d5677ff35766cd884375efc2.tar.gz kernel_samsung_smdk4412-22e0487047567252d5677ff35766cd884375efc2.tar.bz2 | |
USB: xhci: unsigned char never equals -1
There were some places that compared port_speed == -1 where port_speed
is a u8. This doesn't work unless we cast the -1 to u8. Some places
did it correctly.
Instead of using -1 directly, I've created a DUPLICATE_ENTRY define
which does the cast and is more descriptive as well.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Diffstat (limited to 'drivers/usb/host/xhci-ring.c')
| -rw-r--r-- | drivers/usb/host/xhci-ring.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index cfc1ad9..c6d1462 100644 --- a/drivers/usb/host/xhci-ring.c +++ b/drivers/usb/host/xhci-ring.c @@ -1209,7 +1209,7 @@ static unsigned int find_faked_portnum_from_hw_portnum(struct usb_hcd *hcd, * Skip ports that don't have known speeds, or have duplicate * Extended Capabilities port speed entries. */ - if (port_speed == 0 || port_speed == -1) + if (port_speed == 0 || port_speed == DUPLICATE_ENTRY) continue; /* @@ -1260,7 +1260,7 @@ static void handle_port_status(struct xhci_hcd *xhci, port_id); goto cleanup; } - if (major_revision == (u8) -1) { + if (major_revision == DUPLICATE_ENTRY) { xhci_warn(xhci, "Event for port %u duplicated in" "Extended Capabilities, ignoring.\n", port_id); |