aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/serial/mos7840.c
diff options
context:
space:
mode:
authorJohan Hovold <jhovold@gmail.com>2012-10-25 13:35:10 +0200
committerBen Hutchings <ben@decadent.org.uk>2012-10-30 23:27:03 +0000
commit1b5863712a104d321d7321077a2f484edddf5ef3 (patch)
treeddc7871c2409eb97b9a69427a49eabab54f3ae83 /drivers/usb/serial/mos7840.c
parent61824fc04763ad0de619df9d1c2bf441b2f57123 (diff)
downloadkernel_samsung_smdk4412-1b5863712a104d321d7321077a2f484edddf5ef3.zip
kernel_samsung_smdk4412-1b5863712a104d321d7321077a2f484edddf5ef3.tar.gz
kernel_samsung_smdk4412-1b5863712a104d321d7321077a2f484edddf5ef3.tar.bz2
USB: mos7840: fix port-device leak in error path
commit 3eb55cc4ed88eee3b5230f66abcdbd2a91639eda upstream. The driver set the usb-serial port pointers to NULL on errors in attach, effectively preventing usb-serial core from decrementing the port ref counters and releasing the port devices and associated data. Signed-off-by: Johan Hovold <jhovold@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'drivers/usb/serial/mos7840.c')
-rw-r--r--drivers/usb/serial/mos7840.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index e0667a9..feae34e 100644
--- a/drivers/usb/serial/mos7840.c
+++ b/drivers/usb/serial/mos7840.c
@@ -2594,7 +2594,6 @@ error:
kfree(mos7840_port->ctrl_buf);
usb_free_urb(mos7840_port->control_urb);
kfree(mos7840_port);
- serial->port[i] = NULL;
}
return status;
}