aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/serial/usb-serial.c
diff options
context:
space:
mode:
authorMing Lei <tom.leiming@gmail.com>2013-03-26 10:49:55 +0800
committerBen Hutchings <ben@decadent.org.uk>2013-04-25 20:25:25 +0100
commita796ce4827fcbbb269f9e105f6b852b0dec85217 (patch)
treef987f7b4e0905c9c1aa29cc97f1cd5047806aad2 /drivers/usb/serial/usb-serial.c
parentda07f4596510e8141e105c9502a25b568caba860 (diff)
downloadkernel_samsung_smdk4412-a796ce4827fcbbb269f9e105f6b852b0dec85217.zip
kernel_samsung_smdk4412-a796ce4827fcbbb269f9e105f6b852b0dec85217.tar.gz
kernel_samsung_smdk4412-a796ce4827fcbbb269f9e105f6b852b0dec85217.tar.bz2
USB: serial: fix hang when opening port
commit eba0e3c3a0ba7b96f01cbe997680f6a4401a0bfc upstream. Johan's 'fix use-after-free in TIOCMIWAIT' patchset[1] introduces one bug which can cause kernel hang when opening port. This patch initialized the 'port->delta_msr_wait' waitqueue head to fix the bug which is introduced in 3.9-rc4. [1], http://marc.info/?l=linux-usb&m=136368139627876&w=2 Signed-off-by: Ming Lei <tom.leiming@gmail.com> Acked-by: Johan Hovold <jhovold@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'drivers/usb/serial/usb-serial.c')
-rw-r--r--drivers/usb/serial/usb-serial.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
index 2482d5e..850faa4 100644
--- a/drivers/usb/serial/usb-serial.c
+++ b/drivers/usb/serial/usb-serial.c
@@ -905,6 +905,7 @@ int usb_serial_probe(struct usb_interface *interface,
port->port.ops = &serial_port_ops;
port->serial = serial;
spin_lock_init(&port->lock);
+ init_waitqueue_head(&port->delta_msr_wait);
/* Keep this for private driver use for the moment but
should probably go away */
INIT_WORK(&port->work, usb_serial_port_work);