aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/watchdog
diff options
context:
space:
mode:
authorToshi Kani <toshi.kani@hp.com>2012-08-27 12:52:24 -0600
committerBen Hutchings <ben@decadent.org.uk>2012-10-10 03:30:50 +0100
commit6cd1dc6f7e7d273a857c187f92aad2f44dfa7a8d (patch)
tree58e7b1c0f34816f56ff3cad0aab6af9f84fb1307 /drivers/watchdog
parentfbbbb5c0f0efc907bf5e3ff890d7e5a69aa96a21 (diff)
downloadkernel_samsung_smdk4412-6cd1dc6f7e7d273a857c187f92aad2f44dfa7a8d.zip
kernel_samsung_smdk4412-6cd1dc6f7e7d273a857c187f92aad2f44dfa7a8d.tar.gz
kernel_samsung_smdk4412-6cd1dc6f7e7d273a857c187f92aad2f44dfa7a8d.tar.bz2
hpwdt: Fix kdump issue in hpwdt
commit 308b135e4fcc00c80c07e0e04e7afa8edf78583c upstream. kdump can be interrupted by watchdog timer when the timer is left activated on the crash kernel. Changed the hpwdt driver to disable watchdog timer at boot-time. This assures that watchdog timer is disabled until /dev/watchdog is opened, and prevents watchdog timer to be left running on the crash kernel. Signed-off-by: Toshi Kani <toshi.kani@hp.com> Tested-by: Lisa Mitchell <lisa.mitchell@hp.com> Signed-off-by: Thomas Mingarelli <Thomas.Mingarelli@hp.com> Signed-off-by: Wim Van Sebroeck <wim@iguana.be> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'drivers/watchdog')
-rw-r--r--drivers/watchdog/hpwdt.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index 3c166d3..f62be89 100644
--- a/drivers/watchdog/hpwdt.c
+++ b/drivers/watchdog/hpwdt.c
@@ -813,6 +813,9 @@ static int __devinit hpwdt_init_one(struct pci_dev *dev,
hpwdt_timer_reg = pci_mem_addr + 0x70;
hpwdt_timer_con = pci_mem_addr + 0x72;
+ /* Make sure that timer is disabled until /dev/watchdog is opened */
+ hpwdt_stop();
+
/* Make sure that we have a valid soft_margin */
if (hpwdt_change_timer(soft_margin))
hpwdt_change_timer(DEFAULT_MARGIN);