diff options
| author | Nicolas Iooss <nicolas.iooss_linux@m4x.org> | 2015-04-16 12:44:02 -0700 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2015-08-07 00:32:06 +0100 |
| commit | 11efded2cfc62ad72e5e1b666ac09b4e458ee931 (patch) | |
| tree | 9e3bbdcd0f9f79918e1dd4ee85c2fe201227085b /firmware/ihex2fw.c | |
| parent | de49525aa1250da3eac2040591b322d1157831db (diff) | |
| download | kernel_samsung_smdk4412-11efded2cfc62ad72e5e1b666ac09b4e458ee931.zip kernel_samsung_smdk4412-11efded2cfc62ad72e5e1b666ac09b4e458ee931.tar.gz kernel_samsung_smdk4412-11efded2cfc62ad72e5e1b666ac09b4e458ee931.tar.bz2 | |
firmware/ihex2fw.c: restore missing default in switch statement
commit d43698e8abb58a6ac47d16e0f47bb55f452e4fc4 upstream.
Commit 2473238eac95 ("ihex: add support for CS:IP/EIP records") removes
the "default:" statement in the switch block, making the "return
usage();" line dead code and ihex2fw silently ignoring unknown options.
Restore this statement.
This bug was found by building with HOSTCC=clang and adding
-Wunreachable-code-return to HOSTCFLAGS.
Fixes: 2473238eac95 ("ihex: add support for CS:IP/EIP records")
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'firmware/ihex2fw.c')
| -rw-r--r-- | firmware/ihex2fw.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/firmware/ihex2fw.c b/firmware/ihex2fw.c index cf38e15..08d90e2 100644 --- a/firmware/ihex2fw.c +++ b/firmware/ihex2fw.c @@ -86,6 +86,7 @@ int main(int argc, char **argv) case 'j': include_jump = 1; break; + default: return usage(); } } |