diff options
| author | Jeff Layton <jlayton@redhat.com> | 2013-05-07 11:28:31 -0400 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2013-05-30 14:34:55 +0100 |
| commit | 8ac645ff787751eb2d5a80abd7338a4fb838c3a0 (patch) | |
| tree | 0eb725db65753f3aebda34cfaa07d6fc5c9f199f /fs/cifs | |
| parent | c9936e44f19870fcea6835e127a4181005ef06ae (diff) | |
| download | kernel_samsung_smdk4412-8ac645ff787751eb2d5a80abd7338a4fb838c3a0.zip kernel_samsung_smdk4412-8ac645ff787751eb2d5a80abd7338a4fb838c3a0.tar.gz kernel_samsung_smdk4412-8ac645ff787751eb2d5a80abd7338a4fb838c3a0.tar.bz2 | |
cifs: only set ops for inodes in I_NEW state
commit c2b93e0699723700f886ce17bb65ffd771195a6d upstream.
It's generally not safe to reset the inode ops once they've been set. In
the case where the inode was originally thought to be a directory and
then later found to be a DFS referral, this can lead to an oops when we
try to trigger an inode op on it after changing the ops to the blank
referral operations.
Reported-and-Tested-by: Sachin Prabhu <sprabhu@redhat.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <smfrench@gmail.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'fs/cifs')
| -rw-r--r-- | fs/cifs/inode.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index e851d5b..20431b4 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c @@ -173,7 +173,8 @@ cifs_fattr_to_inode(struct inode *inode, struct cifs_fattr *fattr) if (fattr->cf_flags & CIFS_FATTR_DFS_REFERRAL) inode->i_flags |= S_AUTOMOUNT; - cifs_set_ops(inode); + if (inode->i_state & I_NEW) + cifs_set_ops(inode); } void |